SecondCloneSucceedsWithMissingTrees: Attempt 2#336
Merged
derrickstolee merged 2 commits intomicrosoft:masterfrom Oct 4, 2018
Merged
SecondCloneSucceedsWithMissingTrees: Attempt 2#336derrickstolee merged 2 commits intomicrosoft:masterfrom
derrickstolee merged 2 commits intomicrosoft:masterfrom
Conversation
sanoursa
approved these changes
Oct 4, 2018
Contributor
sanoursa
left a comment
sanoursa
left a comment
There was a problem hiding this comment.
This test looks great. Were you able to confirm that it fails without the previous fix?
wilbaker
approved these changes
Oct 4, 2018
Contributor
Author
|
I can only run the functional tests through PR builds, so I'm adding a commit that takes the fix out to verify the test fails. |
derrickstolee
force-pushed
the
checkout-gaps
branch
4 times, most recently
from
c3551e9 to
6adbbd4
Compare
The previous approach to this test relied on deleting packfiles from the shared object cache. That failed on Windows because the .idx files have restrictive permissions that cause the delete to fail. Instead, use the loose object downloads to hydrate the commit and root tree for the WellKnownBranch and then do a clone pointing at that branch. This should trigger the failure case.
This doesn't match, as we expect it to!
derrickstolee
force-pushed
the
checkout-gaps
branch
from
6adbbd4 to
43287ec
Compare
Contributor
Author
|
Ok. I finally got a failed test for the right reason: Trying again with the fix to ensure it passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous approach to this test relied on deleting packfiles from the shared object cache. That failed on Windows because the .idx files have restrictive permissions that cause the delete to fail.
Instead, use the loose object downloads to hydrate the commit and root tree for the WellKnownBranch and then do a clone pointing at that branch. This should trigger the failure case.
Resolves #330