Fix a flaky test involving the background prefetch thread#307
Merged
derrickstolee merged 1 commit intomicrosoft:masterfrom Sep 27, 2018
Merged
Fix a flaky test involving the background prefetch thread#307derrickstolee merged 1 commit intomicrosoft:masterfrom
derrickstolee merged 1 commit intomicrosoft:masterfrom
Conversation
wilbaker
approved these changes
Sep 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functional test
PrefetchCleansUpStalePrefetchLockintends to check the multi-pack-index and commit-graph are completely written after a prefetch. However, this can fail if the test is faster than the background thread in the mount process.This change introduces a 500ms pause in the test to ensure we give adequate time to the mount process before verifying the background thread did its work.