Recursively expand directories before delete and enable folder rename functional tests#272
Conversation
… functional tests
sanoursa
left a comment
There was a problem hiding this comment.
The code looks good but it does potentially introduce more complicated error modes that I'd like to understand better.
GVFS/GVFS.FunctionalTests/Tests/EnlistmentPerFixture/MoveRenameFolderTests.cs
Show resolved
Hide resolved
| { | ||
| if (!TrySendRequestAndWaitForResponse( | ||
| root, | ||
| VDIR == vnodeType ? MessageType_KtoU_NotifyDirectoryPreDelete : MessageType_KtoU_NotifyFilePreDelete, |
There was a problem hiding this comment.
This TrySendRequestAndWaitForResponse and the one below structure their ternary statements differently. I have a preference for how I think it should look, but you can ignore that so long as they're consistent with each other :)
Can we pull the comparison up into a separate variable here too? Additionally, this line is getting long, I'd rather we break it up into 3 separate lines like we do in the below addition.
There was a problem hiding this comment.
This TrySendRequestAndWaitForResponse and the one below structure their ternary statements differently. I have a preference for how I think it should look, but you can ignore that so long as they're consistent with each other
I can make them consistent, but could you provide more details on how you see them as inconsistent?
Can we pull the comparison up into a separate variable here too? Additionally, this line is getting long, I'd rather we break it up into 3 separate lines like we do in the below addition.
Yes to both of these, I'll make the change.
There was a problem hiding this comment.
@nickgra I think I've addressed this feedback with my latest commit, but let me know if there's still changes you'd like to see.
Fixes #202
Summary of changes:
MessageType_KtoU_RecursivelyEnumerateDirectory