Mac: Prevent deletes of the index by non-git processes and enable related functional tests#267
Merged
wilbaker merged 4 commits intomicrosoft:masterfrom Sep 13, 2018
Conversation
…ated functional tests
sanoursa
approved these changes
Sep 13, 2018
Contributor
sanoursa
left a comment
sanoursa
left a comment
There was a problem hiding this comment.
All looks good. Mainly just wondering about the sustainability of sprinkling platform checks throughout the test code.
GVFS/GVFS.FunctionalTests/Tests/EnlistmentPerFixture/GVFSLockTests.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
GVFSLockis not held by gitBashRunnerto expect different messages on Windows and Mac when deletes are blockedBasicFileSystemTests. DeleteIndexFileFailstest on MacGVFSLockTeststests on MacCloses #222