Update PowerShellRunner to support hard link creation and enable more functional tests on Mac#266
Conversation
sanoursa
left a comment
sanoursa
left a comment
There was a problem hiding this comment.
Very minor comments, feel free to take them or not.
| foreach (object[] runner in FileSystemRunner.Runners.ToList()) | ||
| { | ||
| return new[] | ||
| FileSystemRunner fileSystem = runner.ToList().First() as FileSystemRunner; |
There was a problem hiding this comment.
Nit pick: you're using as but not checking for null. I would just do a normal cast here so we end up with a more appropriate exception if someone ever inserts in invalid type into the list.
There was a problem hiding this comment.
I would just do a normal cast here so we end up with a more appropriate exception if someone ever inserts in invalid type into the list.
Sounds good I'll fix this up
| return hardLinkRunners.ToArray(); | ||
| } | ||
|
|
||
| // Always return at least one runner that supports creating hard links |
There was a problem hiding this comment.
Isn't it a bug in our code if we get this far? I would just throw.
There was a problem hiding this comment.
@sanoursa this is not a bug because when we run without --full-suite the only runner will be SystemIORunner which does not support hard link creation.
I can either update the comment to include those details, or I can mark the test as full suite only, let me know if you have a preference.
There was a problem hiding this comment.
Got it, yea a comment would be helpful
There was a problem hiding this comment.
Actually, I just noticed that we had this same issue for RenameDirectory and addressed it by having SystemIORunner.RenameDirectory PInvoke to the native API. I'll see if I can do the same for hard link creation and then all of this "does runner support hard link" code can be removed.
wilbaker
force-pushed
the
powershell_hardlink_and_more_mac_tests
branch
2 times, most recently
from
a3ce35e to
4c38ca0
Compare
wilbaker
force-pushed
the
powershell_hardlink_and_more_mac_tests
branch
from
d160760 to
bc6f896
Compare
2 participants
Fixes #262
CreateHardLinkimplementation toPowerShellRunnerModifiedPathsTestswhen building list of runnersCheckoutTests.CheckoutBranchThatHasFolderShouldGetDeletedtest on MacGitCommands.RebaseTestson Mac