Fix lock issue causing problems in unmounting repository#193
Merged
jamill merged 2 commits intomicrosoft:milestones/M139from Aug 21, 2018
Merged
Fix lock issue causing problems in unmounting repository#193jamill merged 2 commits intomicrosoft:milestones/M139from
jamill merged 2 commits intomicrosoft:milestones/M139from
Conversation
Tweak the order that components are shutdown, to shutdown the GitStatusCache before other components that it depends on. This is to prevent problems that might arise from a component being disabled that GitStatusCache depends on. (cherry picked from commit 0c09ed4)
This fixes a bug in TryAcquireGVFSLockForProcess where it does not correctly report whether it was able to acquire the GVFS lock. In cases where this method retries to acquire the lock, it would report success, even if it was not able to acquire the lock. This could lead to problems where commands that depended on the GVFS could run, even if it did not actually have the lock. (cherry picked from commit dfbe657)
wilbaker
approved these changes
Aug 20, 2018
jrbriggs
approved these changes
Aug 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the main issue that was leading to functional test failures when unmounting repositories.
Due to an bug in the locking logic, the background git status scan (run to rebuild the GitStatusCache), could be denied the GVFS lock, but the command would still be run. This hit other problems later in the command, eventually crashing the GVFS Mount process.
(port pull request #157)