Properly work around Mac GCM issues when the system Java is 8 (or below)#154
Merged
nickgra merged 2 commits intomicrosoft:masterfrom Aug 14, 2018
Merged
Properly work around Mac GCM issues when the system Java is 8 (or below)#154nickgra merged 2 commits intomicrosoft:masterfrom
nickgra merged 2 commits intomicrosoft:masterfrom
Conversation
sanoursa
reviewed
Aug 13, 2018
| @@ -33,15 +33,13 @@ fi | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Unrelated to the current changes, but line 10 above fails with a non-informative error if you run this script before you have built. Might want to just check that the package exists before trying to attach it.
Saeeds-MBP:src sanoursa$ Scripts/Mac/PrepFunctionalTests.sh
hdiutil: attach failed - No such file or directory
Member
Author
There was a problem hiding this comment.
I'll clean that up while I'm here. Thanks!
Contributor
|
This script now works properly on my MacBook |
sanoursa
approved these changes
Aug 13, 2018
… been downloaded yet
wilbaker
approved these changes
Aug 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our prep script that configures machines (dev machines and build agents) to run functional tests has a workaround for an issue with the Git Credential Manager (microsoft/Git-Credential-Manager-for-Mac-and-Linux#71).
This workaround only needs to be applied on machines who's default Java is 9 or 10 (which changed the format of 'java -version'). Applying the workaround to Java 8 installations will instead break the GCM on those machines.
See #155