Explicitly set strict: false for project tests, eval tests, and more programmatic fourslash tests#63024
Merged
DanielRosenwasser merged 4 commits intomainfrom Jan 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR explicitly sets strict: false for existing tests that rely on non-strict mode behavior, as part of the larger effort (#62333) to make --strict the default in TypeScript. The changes ensure these tests continue to work correctly once the default is changed.
Changes:
- Added
"strict": falseto 72 project test configuration JSON files - Updated corresponding baseline JSON files to reflect the new configuration
- Added
// @strict: falsedirective to 10 fourslash test files - Added
strict: falseto theevaluateTypeScriptfunction's default compiler options
Reviewed changes
Copilot reviewed 260 out of 260 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/cases/project/*.json (72 files) | Added "strict": false to project test configurations |
| tests/baselines/reference/project//.json (144 files) | Updated baseline files to reflect the new strict:false setting |
| tests/cases/fourslash/*.ts (10 files) | Added // @strict: false compiler directive |
| src/harness/evaluatorImpl.ts | Added strict: false to default compiler options for eval tests |
jakebailey
approved these changes
Jan 21, 2026
Member
jakebailey
left a comment
There was a problem hiding this comment.
Do the evaluator tests really need strict? Or just alwaysStrict?
Member
Author
I believe they do - I think they consider any diagnostics to be a "syntax error". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #62333.
"strict": falseline added to each project file.evaluateTypeScripttests assumestrictis implicitly off.// @strict: falseI think with this PR and #63023, we may be able to just flip the
strictswitch, accept baselines, and have tests pass.