Fixed lack of errors on missing `JSX.Element` by Andarist · Pull Request #59584 · microsoft/TypeScript

Andarist · 2024-08-10T08:42:29Z

I found this when fixing self-check failure in #59559

typescript-bot · 2024-08-10T08:42:31Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

jakebailey · 2024-08-13T17:22:22Z

@typescript-bot test it

typescript-bot · 2024-08-13T17:22:25Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-08-13T17:42:18Z

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: react-native-razorpay
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/react-native-razorpay/react-native-razorpay-tests.tsx
  40:9   error  TypeScript@local compile error: 
JSX element implicitly has type 'any' because the global type 'JSX.Element' does not exist  @definitelytyped/expect
  41:13  error  TypeScript@local compile error: 
JSX element implicitly has type 'any' because the global type 'JSX.Element' does not exist  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.22_typescript@5.6.0-dev.20240813/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.22_typescript@5.6.0-dev.20240813/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

typescript-bot · 2024-08-13T17:46:20Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59584/merge:

Everything looks good!

typescript-bot · 2024-08-13T18:04:41Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,963k (± 0.73%)}	_{193,578k (± 0.92%)}	_~	_192,302k	_195,951k	_{p=0.378 n=6}
_{Parse Time}	_{1.57s (± 0.63%)}	_{1.56s (± 0.96%)}	_~	_1.54s	_1.58s	_{p=0.563 n=6}
_{Bind Time}	_{0.85s (± 0.98%)}	_{0.86s (± 0.73%)}	_~	_0.85s	_0.87s	_{p=0.340 n=6}
_{Check Time}	_{11.32s (± 0.36%)}	_{11.32s (± 0.88%)}	_~	_11.15s	_11.43s	_{p=0.810 n=6}
_{Emit Time}	_{3.24s (± 0.71%)}	_{3.23s (± 1.08%)}	_~	_3.19s	_3.29s	_{p=0.517 n=6}
_{Total Time}	_{16.98s (± 0.33%)}	_{16.97s (± 0.67%)}	_~	_16.78s	_17.11s	_{p=0.873 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,757	_945,757	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,045	_410,045	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,494k (± 0.00%)}	_{1,222,521k (± 0.00%)}	_~	_1,222,487k	_1,222,547k	_{p=0.378 n=6}
_{Parse Time}	_{7.95s (± 0.69%)}	_{7.94s (± 0.79%)}	_~	_7.88s	_8.05s	_{p=0.873 n=6}
_{Bind Time}	_{2.23s (± 0.37%)}	_{2.23s (± 0.25%)}	_~	_2.22s	_2.23s	_{p=0.441 n=6}
_{Check Time}	_{36.37s (± 0.29%)}	_{36.30s (± 0.46%)}	_~	_36.06s	_36.49s	_{p=0.689 n=6}
_{Emit Time}	_{17.77s (± 0.52%)}	_{17.66s (± 0.60%)}	_~	_17.55s	_17.79s	_{p=0.078 n=6}
_{Total Time}	_{64.31s (± 0.17%)}	_{64.13s (± 0.40%)}	_~	_63.81s	_64.40s	_{p=0.296 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,491,204	_2,491,204	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,013,428	_1,013,428	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,498,602k (± 0.00%)}	_{2,498,546k (± 0.00%)}	_~	_2,498,494k	_2,498,623k	_{p=0.229 n=6}
_{Parse Time}	_{10.97s (± 0.27%)}	_{10.97s (± 0.32%)}	_~	_10.93s	_11.03s	_{p=1.000 n=6}
_{Bind Time}	_{2.62s (± 0.45%)}	_{2.61s (± 0.39%)}	_~	_2.60s	_2.63s	_{p=0.456 n=6}
_{Check Time}	_{89.59s (± 0.51%)}	_{89.23s (± 0.35%)}	_~	_88.71s	_89.63s	_{p=0.261 n=6}
_{Emit Time}	_{0.33s (± 2.29%)}	_{0.33s (± 2.96%)}	_~	_0.32s	_0.34s	_{p=0.554 n=6}
_{Total Time}	_{103.50s (± 0.44%)}	_{103.15s (± 0.30%)}	_~	_102.62s	_103.57s	_{p=0.173 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,395	_1,230,395	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,083	_264,083	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,410,623k (± 6.02%)}	_{2,470,218k (± 7.43%)}	_~	_2,351,124k	_2,707,968k	_{p=0.378 n=6}
_{Parse Time}	_{6.04s (± 0.32%)}	_{6.03s (± 0.71%)}	_~	_5.97s	_6.09s	_{p=0.520 n=6}
_{Bind Time}	_{2.24s (± 0.92%)}	_{2.23s (± 0.73%)}	_~	_2.22s	_2.26s	_{p=0.573 n=6}
_{Check Time}	_{40.65s (± 0.70%)}	_{40.31s (± 0.60%)}	_{-0.34s (- 0.83%)}	_39.91s	_40.56s	_{p=0.020 n=6}
_{Emit Time}	_{4.03s (± 1.99%)}	_{3.98s (± 1.10%)}	_~	_3.95s	_4.07s	_{p=0.149 n=6}
_{Total Time}	_{52.96s (± 0.53%)}	_{52.59s (± 0.48%)}	_{-0.37s (- 0.70%)}	_52.22s	_52.84s	_{p=0.020 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,395	_1,230,395	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,083	_264,083	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,426,254k (± 0.02%)}	_{2,426,019k (± 0.04%)}	_~	_2,425,000k	_2,427,506k	_{p=0.575 n=6}
_{Parse Time}	_{7.76s (± 0.82%)}	_{7.75s (± 0.75%)}	_~	_7.69s	_7.85s	_{p=0.872 n=6}
_{Bind Time}	_{2.52s (± 1.33%)}	_{2.51s (± 1.24%)}	_~	_2.48s	_2.55s	_{p=0.629 n=6}
_{Check Time}	_{51.02s (± 0.53%)}	_{50.87s (± 0.56%)}	_~	_50.52s	_51.39s	_{p=0.173 n=6}
_{Emit Time}	_{5.03s (± 3.51%)}	_{5.10s (± 2.69%)}	_~	_4.98s	_5.28s	_{p=0.128 n=6}
_{Total Time}	_{66.36s (± 0.50%)}	_{66.25s (± 0.51%)}	_~	_65.73s	_66.68s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,891	_256,891	_~	_~	_~	_{p=1.000 n=6}
_Types	_105,580	_105,580	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,190k (± 0.03%)}	_{429,201k (± 0.03%)}	_~	_429,064k	_429,370k	_{p=0.936 n=6}
_{Parse Time}	_{4.17s (± 0.20%)}	_{4.16s (± 0.55%)}	_~	_4.13s	_4.20s	_{p=0.326 n=6}
_{Bind Time}	_{1.60s (± 1.07%)}	_{1.60s (± 0.47%)}	_~	_1.59s	_1.61s	_{p=0.672 n=6}
_{Check Time}	_{22.26s (± 0.49%)}	_{22.26s (± 0.48%)}	_~	_22.15s	_22.44s	_{p=0.872 n=6}
_{Emit Time}	_{2.04s (± 0.80%)}	_{2.03s (± 1.05%)}	_~	_2.00s	_2.05s	_{p=0.515 n=6}
_{Total Time}	_{30.07s (± 0.43%)}	_{30.05s (± 0.43%)}	_~	_29.89s	_30.27s	_{p=0.748 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,245	_94,245	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,178k (± 0.03%)}	_{370,216k (± 0.03%)}	_~	_370,147k	_370,478k	_{p=0.575 n=6}
_{Parse Time}	_{3.42s (± 0.68%)}	_{3.46s (± 0.73%)}	_{+0.03s (+ 0.97%)}	_3.43s	_3.50s	_{p=0.029 n=6}
_{Bind Time}	_{1.93s (± 0.43%)}	_{1.92s (± 0.72%)}	_~	_1.90s	_1.94s	_{p=0.149 n=6}
_{Check Time}	_{19.38s (± 0.26%)}	_{19.36s (± 0.40%)}	_~	_19.24s	_19.47s	_{p=0.872 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.74s (± 0.22%)}	_{24.75s (± 0.29%)}	_~	_24.61s	_24.81s	_{p=0.627 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,000,587	_3,000,587	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,033,624	_1,033,624	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,125,512k (± 0.00%)}	_{3,125,497k (± 0.00%)}	_~	_3,125,382k	_3,125,635k	_{p=0.936 n=6}
_{Parse Time}	_{13.77s (± 0.46%)}	_{13.79s (± 0.12%)}	_~	_13.77s	_13.81s	_{p=0.090 n=6}
_{Bind Time}	_{4.25s (± 0.12%)}	_{4.24s (± 0.33%)}	_~	_4.22s	_4.26s	_{p=0.352 n=6}
_{Check Time}	_{79.02s (± 0.46%)}	_{78.95s (± 0.32%)}	_~	_78.66s	_79.27s	_{p=0.748 n=6}
_{Emit Time}	_{20.31s (± 0.49%)}	_{20.32s (± 0.77%)}	_~	_20.16s	_20.54s	_{p=1.000 n=6}
_{Total Time}	_{117.35s (± 0.30%)}	_{117.30s (± 0.26%)}	_~	_116.83s	_117.64s	_{p=0.873 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_274,381	_274,381	_~	_~	_~	_{p=1.000 n=6}
_Types	_111,850	_111,850	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{420,779k (± 0.01%)}	_{420,736k (± 0.02%)}	_~	_420,646k	_420,877k	_{p=0.298 n=6}
_{Parse Time}	_{4.90s (± 0.75%)}	_{4.88s (± 0.39%)}	_~	_4.85s	_4.90s	_{p=0.192 n=6}
_{Bind Time}	_{2.13s (± 1.18%)}	_{2.13s (± 0.83%)}	_~	_2.10s	_2.14s	_{p=0.934 n=6}
_{Check Time}	_{21.30s (± 0.28%)}	_{21.21s (± 0.62%)}	_~	_21.10s	_21.39s	_{p=0.297 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.32s (± 0.26%)}	_{28.22s (± 0.39%)}	_~	_28.13s	_28.38s	_{p=0.126 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,779	_540,779	_~	_~	_~	_{p=1.000 n=6}
_Types	_177,884	_177,884	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,309k (± 0.01%)}	_{483,331k (± 0.01%)}	_~	_483,249k	_483,410k	_{p=0.873 n=6}
_{Parse Time}	_{4.25s (± 0.69%)}	_{4.26s (± 0.79%)}	_~	_4.22s	_4.31s	_{p=0.871 n=6}
_{Bind Time}	_{1.54s (± 0.68%)}	_{1.55s (± 0.95%)}	_~	_1.54s	_1.57s	_{p=0.557 n=6}
_{Check Time}	_{22.33s (± 0.10%)}	_{22.39s (± 0.39%)}	_~	_22.30s	_22.51s	_{p=0.374 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.12s (± 0.13%)}	_{28.20s (± 0.45%)}	_~	_28.05s	_28.39s	_{p=0.378 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-08-13T19:05:25Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59584/merge:

Something interesting changed - please have a look.

Details

ionic-team/ionic-framework

19 of 20 projects failed to build with the old tsc and were ignored

core/tsconfig.json

error TS2602: JSX element implicitly has type 'any' because the global type 'JSX.Element' does not exist.

typescript-bot · 2024-08-13T19:05:26Z

@jakebailey Here are some more interesting changes from running the top 400 repos suite

Details

ionic-team/ionicons

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2602: JSX element implicitly has type 'any' because the global type 'JSX.Element' does not exist.

Andarist · 2024-08-14T06:55:23Z

The above "breaks" are correct. I created a PR in Stencil to fix this on their side: stenciljs/core#5944

Andarist · 2024-08-19T19:09:53Z

The fix for the above was merged to Stencil's repo

Fixed lack of errors on missing JSX.Element

7a48b2e

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 10, 2024

Andarist mentioned this pull request Aug 10, 2024

Refactor codepaths relying on uncomparable === undefined #59585

Open

Andarist mentioned this pull request Aug 14, 2024

fix(types): expose missing JSX.Element on h stenciljs/core#5944

Merged

2 tasks

Comments

Conversation

Andarist commented Aug 10, 2024

Uh oh!

typescript-bot commented Aug 10, 2024

Uh oh!

jakebailey commented Aug 13, 2024

Uh oh!

typescript-bot commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 13, 2024

Uh oh!

typescript-bot commented Aug 13, 2024

Uh oh!

typescript-bot commented Aug 13, 2024

tsc

Uh oh!

typescript-bot commented Aug 13, 2024

ionic-team/ionic-framework

core/tsconfig.json

Uh oh!

typescript-bot commented Aug 13, 2024

ionic-team/ionicons

tsconfig.json

Uh oh!

Andarist commented Aug 14, 2024

Uh oh!

Andarist commented Aug 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-bot commented Aug 13, 2024 •

edited

Loading