Contextually type array elements using index signatures#58288
Open
Andarist wants to merge 2 commits intomicrosoft:mainfrom
Open
Contextually type array elements using index signatures#58288Andarist wants to merge 2 commits intomicrosoft:mainfrom
Andarist wants to merge 2 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Andarist
commented
Apr 22, 2024
| // iterated or element type of the contextual type. | ||
| return (!firstSpreadIndex || index < firstSpreadIndex) && getTypeOfPropertyOfContextualType(t, "" + index as __String) || | ||
| getIteratedTypeOrElementType(IterationUse.Element, t, undefinedType, /*errorNode*/ undefined, /*checkAssignability*/ false); | ||
| return (firstSpreadIndex === undefined || index < firstSpreadIndex) && getTypeOfPropertyOfContextualType(t, "" + index as __String) || |
Contributor
Author
There was a problem hiding this comment.
We have 2 fixes here
!firstSpreadIndex->firstSpreadIndex === undefined. This fixes contextual parameter type here. It is not assigned correctly today. This PR makes it an implicit any which is better than the incorrect assignment.- I also start using applicable index info as a fallback here. This covers cases when
tis just an array-like that uses index signatures - that's not something thatgetIteratedTypeOrElementTypehandles today.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…t-types-from-index-signatures
typescript-bot
added
For Backlog Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #58286