Omit intersection property check when source includes target by ahejlsberg · Pull Request #53012 · microsoft/TypeScript

ahejlsberg · 2023-02-28T02:25:15Z

ahejlsberg · 2023-02-28T02:26:48Z

No regression test included, but I have manually verified that this causes material-ui to successfully compile.

ahejlsberg · 2023-02-28T02:30:33Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2023-02-28T02:30:37Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at f8eea3a. You can monitor the build here.

typescript-bot · 2023-02-28T02:30:37Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at f8eea3a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-28T02:30:37Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at f8eea3a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-28T02:30:37Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at f8eea3a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-28T02:30:37Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at f8eea3a. You can monitor the build here.

typescript-bot · 2023-02-28T02:42:50Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/53012/merge:

Everything looks good!

typescript-bot · 2023-02-28T02:45:49Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53012

_Metric	_main	₅₃₀₁₂	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{359,064k (± 0.00%)}	_{359,071k (± 0.01%)}	_~	_359,042k	_359,095k	_{p=0.575 n=6}
_{Parse Time}	_{3.73s (± 0.46%)}	_{3.75s (± 0.66%)}	_~	_3.72s	_3.79s	_{p=0.256 n=6}
_{Bind Time}	_{1.19s (± 0.75%)}	_{1.19s (± 0.63%)}	_~	_1.18s	_1.20s	_{p=0.798 n=6}
_{Check Time}	_{9.42s (± 0.98%)}	_{9.47s (± 0.75%)}	_~	_9.38s	_9.59s	_{p=0.226 n=6}
_{Emit Time}	_{7.95s (± 0.67%)}	_{7.94s (± 0.36%)}	_~	_7.92s	_8.00s	_{p=0.688 n=6}
_{Total Time}	_{22.29s (± 0.59%)}	_{22.35s (± 0.43%)}	_~	_22.27s	_22.51s	_{p=0.468 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,466k (± 0.87%)}	_{191,263k (± 0.02%)}	_{-1,203k (- 0.63%)}	_191,207k	_191,295k	_{p=0.005 n=6}
_{Parse Time}	_{1.56s (± 0.99%)}	_{1.57s (± 0.35%)}	_~	_1.56s	_1.57s	_{p=0.675 n=6}
_{Bind Time}	_{0.82s (± 0.50%)}	_{0.82s (± 0.63%)}	_~	_0.82s	_0.83s	_{p=0.595 n=6}
_{Check Time}	_{10.12s (± 0.60%)}	_{10.11s (± 0.36%)}	_~	_10.07s	_10.17s	_{p=0.747 n=6}
_{Emit Time}	_{3.01s (± 0.35%)}	_{2.99s (± 1.03%)}	_~	_2.96s	_3.04s	_{p=0.375 n=6}
_{Total Time}	_{15.50s (± 0.35%)}	_{15.49s (± 0.37%)}	_~	_15.43s	_15.59s	_{p=0.936 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,118k (± 0.01%)}	_{343,124k (± 0.00%)}	_~	_343,109k	_343,141k	_{p=0.630 n=6}
_{Parse Time}	_{2.80s (± 0.57%)}	_{2.79s (± 0.59%)}	_~	_2.78s	_2.82s	_{p=0.461 n=6}
_{Bind Time}	_{1.08s (± 1.23%)}	_{1.08s (± 0.48%)}	_~	_1.08s	_1.09s	_{p=0.928 n=6}
_{Check Time}	_{7.70s (± 0.48%)}	_{7.66s (± 0.39%)}	_~	_7.62s	_7.70s	_{p=0.170 n=6}
_{Emit Time}	_{4.43s (± 0.65%)}	_{4.42s (± 0.25%)}	_~	_4.40s	_4.43s	_{p=0.329 n=6}
_{Total Time}	_{16.01s (± 0.31%)}	_{15.96s (± 0.23%)}	_~	_15.91s	_16.01s	_{p=0.126 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,254k (± 0.01%)}	_{299,249k (± 0.01%)}	_~	_299,220k	_299,282k	_{p=0.575 n=6}
_{Parse Time}	_{2.16s (± 0.63%)}	_{2.17s (± 1.18%)}	_~	_2.14s	_2.20s	_{p=0.680 n=6}
_{Bind Time}	_{1.25s (± 1.40%)}	_{1.24s (± 0.67%)}	_~	_1.23s	_1.25s	_{p=0.933 n=6}
_{Check Time}	_{7.15s (± 0.33%)}	_{7.20s (± 0.40%)}	_{+0.05s (+ 0.75%)}	_7.16s	_7.24s	_{p=0.012 n=6}
_{Emit Time}	_{4.33s (± 0.40%)}	_{4.34s (± 0.75%)}	_~	_4.31s	_4.38s	_{p=0.739 n=6}
_{Total Time}	_{14.88s (± 0.29%)}	_{14.96s (± 0.29%)}	_{+0.07s (+ 0.50%)}	_14.91s	_15.03s	_{p=0.029 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{475,670k (± 0.01%)}	_{475,650k (± 0.00%)}	_~	_475,622k	_475,670k	_{p=0.810 n=6}
_{Parse Time}	_{3.31s (± 0.37%)}	_{3.30s (± 0.52%)}	_~	_3.28s	_3.33s	_{p=0.357 n=6}
_{Bind Time}	_{0.96s (± 0.54%)}	_{0.96s (± 1.09%)}	_~	_0.95s	_0.98s	_{p=0.794 n=6}
_{Check Time}	_{18.05s (± 0.39%)}	_{18.25s (± 0.76%)}	_{+0.20s (+ 1.11%)}	_18.03s	_18.38s	_{p=0.037 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.31s (± 0.34%)}	_{22.51s (± 0.65%)}	_{+0.20s (+ 0.90%)}	_22.27s	_22.64s	_{p=0.045 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{545,785k (± 0.03%)}	_{545,710k (± 0.03%)}	_~	_545,551k	_546,059k	_{p=0.378 n=6}
_{Parse Time}	_{4.29s (± 0.52%)}	_{4.30s (± 0.48%)}	_~	_4.27s	_4.33s	_{p=0.518 n=6}
_{Bind Time}	_{1.77s (± 0.62%)}	_{1.77s (± 0.58%)}	_~	_1.75s	_1.78s	_{p=0.863 n=6}
_{Check Time}	_{2.99s (± 0.50%)}	_{2.98s (± 0.51%)}	_~	_2.97s	_3.01s	_{p=0.871 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.14s (± 0.34%)}	_{9.13s (± 0.34%)}	_~	_9.09s	_9.18s	_{p=1.000 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₀₁₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

jakebailey · 2023-02-28T03:34:59Z

Just rechecking in case those two regressions are just noise. I'm pretty sure they are.

@typescript-bot perf test

typescript-bot · 2023-02-28T03:35:26Z

Heya @jakebailey, I've started to run the perf test suite on this PR at f8eea3a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-28T04:09:14Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/53012/merge:

Everything looks good!

typescript-bot · 2023-02-28T04:31:01Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53012

_Metric	_main	₅₃₀₁₂	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{359,744k (± 0.01%)}	_{359,767k (± 0.01%)}	_~	_359,691k	_359,828k	_{p=0.471 n=6}
_{Parse Time}	_{3.51s (± 1.13%)}	_{3.49s (± 0.79%)}	_~	_3.46s	_3.53s	_{p=0.514 n=6}
_{Bind Time}	_{1.13s (± 1.03%)}	_{1.13s (± 0.92%)}	_~	_1.11s	_1.14s	_{p=0.615 n=6}
_{Check Time}	_{8.69s (± 0.78%)}	_{8.64s (± 0.40%)}	_~	_8.60s	_8.69s	_{p=0.294 n=6}
_{Emit Time}	_{7.47s (± 0.70%)}	_{7.41s (± 0.50%)}	_~	_7.37s	_7.47s	_{p=0.054 n=6}
_{Total Time}	_{20.80s (± 0.70%)}	_{20.67s (± 0.47%)}	_~	_20.54s	_20.83s	_{p=0.199 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{192,561k (± 1.60%)}	_{190,542k (± 1.24%)}	_{-2,019k (- 1.05%)}	_189,481k	_195,354k	_{p=0.045 n=6}
_{Parse Time}	_{1.49s (± 0.66%)}	_{1.48s (± 0.92%)}	_~	_1.46s	_1.50s	_{p=0.111 n=6}
_{Bind Time}	_{0.77s (± 1.27%)}	_{0.77s (± 0.67%)}	_~	_0.76s	_0.77s	_{p=0.386 n=6}
_{Check Time}	_{9.34s (± 0.61%)}	_{9.38s (± 0.69%)}	_~	_9.29s	_9.45s	_{p=0.376 n=6}
_{Emit Time}	_{2.73s (± 0.57%)}	_{2.72s (± 0.71%)}	_~	_2.70s	_2.75s	_{p=0.413 n=6}
_{Total Time}	_{14.33s (± 0.50%)}	_{14.34s (± 0.44%)}	_~	_14.25s	_14.40s	_{p=0.936 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{343,859k (± 0.02%)}	_{343,856k (± 0.01%)}	_~	_343,831k	_343,921k	_{p=0.810 n=6}
_{Parse Time}	_{2.63s (± 0.61%)}	_{2.63s (± 1.16%)}	_~	_2.59s	_2.67s	_{p=0.618 n=6}
_{Bind Time}	_{1.01s (± 0.40%)}	_{1.01s (± 0.51%)}	_~	_1.00s	_1.01s	_{p=0.114 n=6}
_{Check Time}	_{6.99s (± 0.31%)}	_{7.02s (± 0.42%)}	_~	_6.98s	_7.05s	_{p=0.147 n=6}
_{Emit Time}	_{4.20s (± 1.03%)}	_{4.21s (± 0.92%)}	_~	_4.16s	_4.26s	_{p=0.574 n=6}
_{Total Time}	_{14.83s (± 0.33%)}	_{14.87s (± 0.39%)}	_~	_14.81s	_14.93s	_{p=0.293 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{299,865k (± 0.01%)}	_{299,897k (± 0.01%)}	_{+33k (+ 0.01%)}	_299,870k	_299,928k	_{p=0.031 n=6}
_{Parse Time}	_{2.02s (± 0.94%)}	_{2.04s (± 0.91%)}	_~	_2.01s	_2.06s	_{p=0.195 n=6}
_{Bind Time}	_{1.14s (± 0.48%)}	_{1.11s (± 6.18%)}	_~	_0.97s	_1.14s	_{p=0.855 n=6}
_{Check Time}	_{6.50s (± 0.79%)}	_{6.51s (± 0.44%)}	_~	_6.48s	_6.55s	_{p=0.571 n=6}
_{Emit Time}	_{3.85s (± 0.63%)}	_{3.85s (± 0.93%)}	_~	_3.80s	_3.90s	_{p=0.872 n=6}
_{Total Time}	_{13.51s (± 0.43%)}	_{13.51s (± 0.49%)}	_~	_13.42s	_13.60s	_{p=1.000 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{476,387k (± 0.00%)}	_{476,407k (± 0.00%)}	_~	_476,375k	_476,431k	_{p=0.173 n=6}
_{Parse Time}	_{3.13s (± 0.83%)}	_{3.13s (± 0.44%)}	_~	_3.12s	_3.16s	_{p=0.292 n=6}
_{Bind Time}	_{0.92s (± 0.60%)}	_{0.91s (± 1.08%)}	_~	_0.90s	_0.93s	_{p=0.322 n=6}
_{Check Time}	_{17.22s (± 0.99%)}	_{17.02s (± 0.41%)}	_{-0.20s (- 1.19%)}	_16.93s	_17.11s	_{p=0.030 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.26s (± 0.88%)}	_{21.06s (± 0.36%)}	_{-0.20s (- 0.96%)}	_20.97s	_21.17s	_{p=0.045 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{548,192k (± 0.02%)}	_{548,062k (± 0.03%)}	_~	_547,918k	_548,288k	_{p=0.230 n=6}
_{Parse Time}	_{4.08s (± 0.48%)}	_{4.08s (± 0.81%)}	_~	_4.03s	_4.12s	_{p=0.683 n=6}
_{Bind Time}	_{1.68s (± 0.49%)}	_{1.67s (± 0.31%)}	_{-0.01s (- 0.60%)}	_1.66s	_1.67s	_{p=0.039 n=6}
_{Check Time}	_{2.77s (± 0.87%)}	_{2.75s (± 0.82%)}	_~	_2.73s	_2.79s	_{p=0.147 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.61s (± 0.40%)}	_{8.59s (± 0.55%)}	_~	_8.52s	_8.66s	_{p=0.334 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{359,064k (± 0.00%)}	_{359,068k (± 0.01%)}	_~	_359,032k	_359,087k	_{p=0.423 n=6}
_{Parse Time}	_{3.73s (± 0.46%)}	_{3.73s (± 0.26%)}	_~	_3.72s	_3.74s	_{p=0.869 n=6}
_{Bind Time}	_{1.19s (± 0.75%)}	_{1.19s (± 0.00%)}	_~	_1.19s	_1.19s	_{p=1.000 n=6}
_{Check Time}	_{9.42s (± 0.98%)}	_{9.45s (± 0.42%)}	_~	_9.39s	_9.51s	_{p=0.196 n=6}
_{Emit Time}	_{7.95s (± 0.67%)}	_{7.92s (± 0.65%)}	_~	_7.88s	_8.02s	_{p=0.518 n=6}
_{Total Time}	_{22.29s (± 0.59%)}	_{22.29s (± 0.38%)}	_~	_22.20s	_22.44s	_{p=0.936 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,466k (± 0.87%)}	_{191,834k (± 0.70%)}	_~	_191,219k	_194,561k	_{p=0.128 n=6}
_{Parse Time}	_{1.56s (± 0.99%)}	_{1.56s (± 0.91%)}	_~	_1.54s	_1.58s	_{p=1.000 n=6}
_{Bind Time}	_{0.82s (± 0.50%)}	_{0.82s (± 0.50%)}	_~	_0.82s	_0.83s	_{p=1.000 n=6}
_{Check Time}	_{10.12s (± 0.60%)}	_{10.07s (± 0.50%)}	_~	_10.01s	_10.13s	_{p=0.470 n=6}
_{Emit Time}	_{3.01s (± 0.35%)}	_{2.99s (± 0.88%)}	_~	_2.95s	_3.02s	_{p=0.370 n=6}
_{Total Time}	_{15.50s (± 0.35%)}	_{15.45s (± 0.40%)}	_~	_15.36s	_15.52s	_{p=0.334 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,118k (± 0.01%)}	_{343,130k (± 0.01%)}	_~	_343,098k	_343,147k	_{p=0.298 n=6}
_{Parse Time}	_{2.80s (± 0.57%)}	_{2.79s (± 0.87%)}	_~	_2.76s	_2.83s	_{p=0.517 n=6}
_{Bind Time}	_{1.08s (± 1.23%)}	_{1.08s (± 0.75%)}	_~	_1.07s	_1.09s	_{p=0.866 n=6}
_{Check Time}	_{7.70s (± 0.48%)}	_{7.68s (± 0.27%)}	_~	_7.64s	_7.70s	_{p=0.468 n=6}
_{Emit Time}	_{4.43s (± 0.65%)}	_{4.42s (± 0.42%)}	_~	_4.39s	_4.44s	_{p=0.570 n=6}
_{Total Time}	_{16.01s (± 0.31%)}	_{15.98s (± 0.16%)}	_~	_15.96s	_16.02s	_{p=0.250 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,254k (± 0.01%)}	_{299,240k (± 0.01%)}	_~	_299,197k	_299,276k	_{p=0.471 n=6}
_{Parse Time}	_{2.16s (± 0.63%)}	_{2.16s (± 1.12%)}	_~	_2.12s	_2.18s	_{p=0.289 n=6}
_{Bind Time}	_{1.25s (± 1.40%)}	_{1.24s (± 1.07%)}	_~	_1.22s	_1.25s	_{p=0.461 n=6}
_{Check Time}	_{7.15s (± 0.33%)}	_{7.17s (± 0.31%)}	_~	_7.13s	_7.19s	_{p=0.195 n=6}
_{Emit Time}	_{4.33s (± 0.40%)}	_{4.33s (± 0.48%)}	_~	_4.29s	_4.34s	_{p=0.802 n=6}
_{Total Time}	_{14.88s (± 0.29%)}	_{14.90s (± 0.36%)}	_~	_14.82s	_14.96s	_{p=0.567 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{475,670k (± 0.01%)}	_{475,652k (± 0.00%)}	_~	_475,637k	_475,663k	_{p=0.575 n=6}
_{Parse Time}	_{3.31s (± 0.37%)}	_{3.29s (± 0.19%)}	_{-0.02s (- 0.45%)}	_3.28s	_3.30s	_{p=0.027 n=6}
_{Bind Time}	_{0.96s (± 0.54%)}	_{0.96s (± 0.78%)}	_~	_0.95s	_0.97s	_{p=0.241 n=6}
_{Check Time}	_{18.05s (± 0.39%)}	_{18.15s (± 0.88%)}	_~	_18.01s	_18.42s	_{p=0.336 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.31s (± 0.34%)}	_{22.40s (± 0.73%)}	_~	_22.25s	_22.67s	_{p=0.471 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{545,785k (± 0.03%)}	_{545,658k (± 0.02%)}	_~	_545,545k	_545,753k	_{p=0.378 n=6}
_{Parse Time}	_{4.29s (± 0.52%)}	_{4.30s (± 0.32%)}	_~	_4.27s	_4.31s	_{p=0.686 n=6}
_{Bind Time}	_{1.77s (± 0.62%)}	_{1.77s (± 0.46%)}	_~	_1.76s	_1.78s	_{p=0.666 n=6}
_{Check Time}	_{2.99s (± 0.50%)}	_{2.98s (± 0.63%)}	_~	_2.97s	_3.02s	_{p=0.569 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.14s (± 0.34%)}	_{9.13s (± 0.26%)}	_~	_9.10s	_9.16s	_{p=1.000 n=6}
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{352,813k (± 0.01%)}	_{352,815k (± 0.00%)}	_~	_352,800k	_352,835k	_{p=0.873 n=6}
_{Parse Time}	_{3.71s (± 1.03%)}	_{3.69s (± 0.40%)}	_~	_3.67s	_3.71s	_{p=0.226 n=6}
_{Bind Time}	_{1.24s (± 0.44%)}	_{1.24s (± 0.33%)}	_~	_1.24s	_1.25s	_{p=0.282 n=6}
_{Check Time}	_{9.73s (± 0.37%)}	_{9.68s (± 0.36%)}	_~	_9.63s	_9.73s	_{p=0.107 n=6}
_{Emit Time}	_{8.38s (± 0.55%)}	_{8.35s (± 0.68%)}	_~	_8.26s	_8.42s	_{p=0.628 n=6}
_{Total Time}	_{23.06s (± 0.26%)}	_{22.97s (± 0.33%)}	_~	_22.84s	_23.03s	_{p=0.108 n=6}
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{186,589k (± 0.01%)}	_{186,544k (± 0.01%)}	_{-45k (- 0.02%)}	_186,502k	_186,569k	_{p=0.008 n=6}
_{Parse Time}	_{1.58s (± 0.74%)}	_{1.57s (± 0.52%)}	_~	_1.56s	_1.58s	_{p=0.401 n=6}
_{Bind Time}	_{0.84s (± 0.48%)}	_{0.84s (± 0.49%)}	_~	_0.83s	_0.84s	_{p=0.218 n=6}
_{Check Time}	_{10.19s (± 0.58%)}	_{10.18s (± 0.41%)}	_~	_10.10s	_10.22s	_{p=0.871 n=6}
_{Emit Time}	_{3.13s (± 0.81%)}	_{3.14s (± 1.48%)}	_~	_3.10s	_3.23s	_{p=0.935 n=6}
_{Total Time}	_{15.73s (± 0.42%)}	_{15.73s (± 0.43%)}	_~	_15.62s	_15.82s	_{p=0.936 n=6}
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{338,118k (± 0.00%)}	_{338,115k (± 0.01%)}	_~	_338,080k	_338,149k	_{p=1.000 n=6}
_{Parse Time}	_{2.88s (± 0.68%)}	_{2.88s (± 0.52%)}	_~	_2.86s	_2.89s	_{p=0.493 n=6}
_{Bind Time}	_{1.10s (± 0.37%)}	_{1.11s (± 1.05%)}	_~	_1.09s	_1.12s	_{p=0.102 n=6}
_{Check Time}	_{8.10s (± 0.35%)}	_{8.05s (± 0.33%)}	_{-0.05s (- 0.68%)}	_8.01s	_8.09s	_{p=0.015 n=6}
_{Emit Time}	_{4.69s (± 0.93%)}	_{4.69s (± 1.12%)}	_~	_4.66s	_4.80s	_{p=1.000 n=6}
_{Total Time}	_{16.78s (± 0.33%)}	_{16.73s (± 0.41%)}	_~	_16.66s	_16.85s	_{p=0.170 n=6}
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{294,291k (± 0.00%)}	_{294,292k (± 0.00%)}	_~	_294,284k	_294,302k	_{p=0.748 n=6}
_{Parse Time}	_{2.38s (± 0.94%)}	_{2.37s (± 0.60%)}	_~	_2.35s	_2.39s	_{p=0.371 n=6}
_{Bind Time}	_{1.07s (± 0.48%)}	_{1.06s (± 0.38%)}	_~	_1.06s	_1.07s	_{p=0.112 n=6}
_{Check Time}	_{7.50s (± 0.57%)}	_{7.47s (± 0.62%)}	_~	_7.42s	_7.55s	_{p=0.199 n=6}
_{Emit Time}	_{4.29s (± 1.43%)}	_{4.29s (± 0.12%)}	_~	_4.28s	_4.29s	_{p=0.082 n=6}
_{Total Time}	_{15.24s (± 0.64%)}	_{15.19s (± 0.28%)}	_~	_15.13s	_15.25s	_{p=0.336 n=6}
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{471,301k (± 0.01%)}	_{471,338k (± 0.01%)}	_~	_471,308k	_471,376k	_{p=0.066 n=6}
_{Parse Time}	_{3.45s (± 0.45%)}	_{3.46s (± 0.51%)}	_~	_3.44s	_3.48s	_{p=0.615 n=6}
_{Bind Time}	_{1.01s (± 0.88%)}	_{1.00s (± 0.54%)}	_~	_1.00s	_1.01s	_{p=0.341 n=6}
_{Check Time}	_{19.04s (± 0.81%)}	_{19.04s (± 0.80%)}	_~	_18.83s	_19.23s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.50s (± 0.67%)}	_{23.50s (± 0.69%)}	_~	_23.29s	_23.70s	_{p=1.000 n=6}
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{534,520k (± 0.00%)}	_{534,383k (± 0.00%)}	_{-138k (- 0.03%)}	_534,359k	_534,421k	_{p=0.005 n=6}
_{Parse Time}	_{4.51s (± 1.80%)}	_{4.52s (± 1.52%)}	_~	_4.43s	_4.58s	_{p=1.000 n=6}
_{Bind Time}	_{1.74s (± 4.13%)}	_{1.70s (± 3.05%)}	_~	_1.66s	_1.79s	_{p=0.254 n=6}
_{Check Time}	_{3.17s (± 0.26%)}	_{3.12s (± 0.74%)}	_{-0.04s (- 1.37%)}	_3.09s	_3.16s	_{p=0.004 n=6}
_{Emit Time}	_{0.10s (± 0.00%)}	_{0.10s (± 0.00%)}	_~	_0.10s	_0.10s	_{p=1.000 n=6}
_{Total Time}	_{9.52s (± 0.19%)}	_{9.44s (± 0.40%)}	_{-0.08s (- 0.84%)}	_9.38s	_9.49s	_{p=0.006 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₀₁₂	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..53012

_Metric	_main	₅₃₀₁₂	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,361ms (± 0.44%)}	_{2,371ms (± 1.17%)}	_~	_2,352ms	_2,425ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{5,318ms (± 1.02%)}	_{5,310ms (± 0.80%)}	_~	_5,240ms	_5,362ms	_{p=1.000 n=6}
_{Req 3 - references}	_{338ms (± 1.37%)}	_{339ms (± 2.12%)}	_~	_334ms	_353ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{285ms (± 1.12%)}	_{284ms (± 0.88%)}	_~	_281ms	_288ms	_{p=0.625 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{73ms (± 5.07%)}	_{74ms (± 5.83%)}	_~	_69ms	_79ms	_{p=0.935 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,519ms (± 1.15%)}	_{2,516ms (± 1.03%)}	_~	_2,468ms	_2,546ms	_{p=0.873 n=6}
_{Req 2 - geterr}	_{3,978ms (± 0.77%)}	_{3,985ms (± 0.64%)}	_~	_3,948ms	_4,018ms	_{p=0.575 n=6}
_{Req 3 - references}	_{351ms (± 0.50%)}	_{354ms (± 0.44%)}	_{+3ms (+ 0.76%)}	_352ms	_356ms	_{p=0.029 n=6}
_{Req 4 - navto}	_{292ms (± 0.31%)}	_{293ms (± 0.19%)}	_~	_292ms	_293ms	_{p=0.341 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{70ms (± 8.42%)}	_{69ms (± 1.22%)}	_~	_68ms	_70ms	_{p=0.325 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,167ms (± 0.65%)}	_{3,165ms (± 0.24%)}	_~	_3,156ms	_3,173ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{1,616ms (± 0.82%)}	_{1,603ms (± 0.51%)}	_{-14ms (- 0.84%)}	_1,589ms	_1,613ms	_{p=0.045 n=6}
_{Req 3 - references}	_{105ms (± 3.83%)}	_{105ms (± 1.94%)}	_~	_103ms	_108ms	_{p=0.677 n=6}
_{Req 4 - navto}	_{361ms (± 0.38%)}	_{359ms (± 0.51%)}	_{-2ms (- 0.60%)}	_356ms	_361ms	_{p=0.046 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,136 (± 0.00%)}	_~	_3,136	_3,136	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{430ms (± 1.25%)}	_{429ms (± 0.85%)}	_~	_425ms	_436ms	_{p=0.421 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,528ms (± 1.52%)}	_{2,473ms (± 1.20%)}	_{-55ms (- 2.16%)}	_2,448ms	_2,532ms	_{p=0.045 n=6}
_{Req 2 - geterr}	_{5,690ms (± 0.50%)}	_{5,697ms (± 0.60%)}	_~	_5,653ms	_5,748ms	_{p=0.810 n=6}
_{Req 3 - references}	_{348ms (± 0.35%)}	_{350ms (± 0.94%)}	_~	_346ms	_355ms	_{p=0.373 n=6}
_{Req 4 - navto}	_{280ms (± 0.37%)}	_{280ms (± 1.04%)}	_~	_276ms	_285ms	_{p=0.803 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 1.06%)}	_{87ms (± 4.99%)}	_~	_84ms	_95ms	_{p=0.084 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,675ms (± 0.41%)}	_{2,665ms (± 0.96%)}	_~	_2,624ms	_2,693ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{4,343ms (± 0.59%)}	_{4,337ms (± 0.51%)}	_~	_4,302ms	_4,359ms	_{p=0.936 n=6}
_{Req 3 - references}	_{364ms (± 1.14%)}	_{365ms (± 1.21%)}	_~	_357ms	_369ms	_{p=0.290 n=6}
_{Req 4 - navto}	_{289ms (± 1.06%)}	_{287ms (± 1.23%)}	_~	_283ms	_292ms	_{p=0.333 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{73ms (± 0.71%)}	_{74ms (± 3.34%)}	_~	_72ms	_79ms	_{p=0.142 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,331ms (± 0.40%)}	_{3,328ms (± 0.31%)}	_~	_3,313ms	_3,340ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{1,776ms (± 0.92%)}	_{1,769ms (± 1.14%)}	_~	_1,749ms	_1,797ms	_{p=0.423 n=6}
_{Req 3 - references}	_{112ms (± 2.26%)}	_{111ms (± 2.39%)}	_~	_109ms	_115ms	_{p=0.737 n=6}
_{Req 4 - navto}	_{346ms (± 0.99%)}	_{342ms (± 0.91%)}	_~	_339ms	_347ms	_{p=0.107 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,136 (± 0.00%)}	_~	_3,136	_3,136	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{436ms (± 0.93%)}	_{437ms (± 0.51%)}	_~	_434ms	_440ms	_{p=0.517 n=6}
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,583ms (± 0.59%)}	_{2,570ms (± 0.96%)}	_~	_2,525ms	_2,591ms	_{p=0.423 n=6}
_{Req 2 - geterr}	_{6,002ms (± 0.38%)}	_{6,023ms (± 0.54%)}	_~	_5,990ms	_6,074ms	_{p=0.298 n=6}
_{Req 3 - references}	_{365ms (± 0.62%)}	_{365ms (± 0.55%)}	_~	_362ms	_368ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{278ms (± 1.94%)}	_{275ms (± 1.04%)}	_~	_273ms	_281ms	_{p=0.558 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{96ms (± 8.13%)}	_{100ms (± 1.77%)}	_~	_96ms	_101ms	_{p=0.931 n=6}
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,811ms (± 0.32%)}	_{2,818ms (± 0.63%)}	_~	_2,791ms	_2,832ms	_{p=0.335 n=6}
_{Req 2 - geterr}	_{4,474ms (± 2.36%)}	_{4,435ms (± 1.60%)}	_~	_4,393ms	_4,579ms	_{p=0.575 n=6}
_{Req 3 - references}	_{403ms (± 6.23%)}	_{388ms (± 5.56%)}	_~	_377ms	_432ms	_{p=0.469 n=6}
_{Req 4 - navto}	_{290ms (± 1.47%)}	_{293ms (± 1.59%)}	_~	_286ms	_297ms	_{p=0.376 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{90ms (± 8.24%)}	_{92ms (±10.03%)}	_~	_83ms	_102ms	_{p=0.570 n=6}
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,651ms (± 0.72%)}	_{3,635ms (± 0.59%)}	_~	_3,595ms	_3,651ms	_{p=0.521 n=6}
_{Req 2 - geterr}	_{1,846ms (± 0.69%)}	_{1,838ms (± 1.33%)}	_~	_1,817ms	_1,881ms	_{p=0.378 n=6}
_{Req 3 - references}	_{128ms (± 3.02%)}	_{129ms (± 2.50%)}	_~	_125ms	_133ms	_{p=0.871 n=6}
_{Req 4 - navto}	_{372ms (± 0.88%)}	_{377ms (± 1.76%)}	_~	_372ms	_390ms	_{p=0.122 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,136 (± 0.00%)}	_~	_3,136	_3,136	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{450ms (± 1.39%)}	_{461ms (± 2.80%)}	_~	_444ms	_475ms	_{p=0.226 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₀₁₂	₆
_Baseline	_main	₆

Startup

Comparison Report - main..53012

_Metric	_main	₅₃₀₁₂	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{143.01ms (± 0.22%)}	_{142.76ms (± 0.21%)}	_{-0.25ms (- 0.17%)}	_142.11ms	_146.54ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{228.46ms (± 0.26%)}	_{227.89ms (± 0.17%)}	_{-0.57ms (- 0.25%)}	_226.68ms	_232.20ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{230.34ms (± 0.30%)}	_{229.35ms (± 0.15%)}	_{-0.99ms (- 0.43%)}	_228.43ms	_234.34ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{211.91ms (± 0.34%)}	_{210.19ms (± 0.16%)}	_{-1.72ms (- 0.81%)}	_209.23ms	_214.75ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₀₁₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

DanielRosenwasser · 2023-02-28T05:32:20Z

~~Is the affected test case in this PR representative of the 5.0 regression we saw in the latest material-ui?~~ I just saw #53012 (comment). If we can figure out a minimal test case, seems like we should add one and then cherry-pick this to release-5.0.

I don't know if it's worth holding up the RC since it accidentally got published to NuGet yesterday anyway - but we can talk about it tomorrow.

ahejlsberg · 2023-02-28T14:57:04Z

Tests and performance all look good. Merging.

jakebailey · 2023-02-28T19:03:51Z

@typescript-bot cherry-pick this to release-5.0

typescript-bot · 2023-02-28T19:03:55Z

Heya @jakebailey, I've started to run the task to cherry-pick this into release-5.0 on this PR at f8eea3a. You can monitor the build here.

typescript-bot · 2023-02-28T19:08:38Z

Hey @jakebailey, I've opened #53024 for you.

Component commits: 2983c85 Omit intersection property check when source includes target f8eea3a Accept new baselines

…e-5.0 (#53024) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

ahejlsberg added 2 commits February 27, 2023 18:19

Omit intersection property check when source includes target

2983c85

Accept new baselines

f8eea3a

typescript-bot assigned ahejlsberg Feb 28, 2023

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Feb 28, 2023

ahejlsberg requested review from DanielRosenwasser and jakebailey February 28, 2023 02:27

jakebailey approved these changes Feb 28, 2023

View reviewed changes

ahejlsberg merged commit 7481434 into main Feb 28, 2023

ahejlsberg deleted the fix53009 branch February 28, 2023 14:57

typescript-bot mentioned this pull request Feb 28, 2023

🤖 Pick PR #53012 (Omit intersection property check wh...) into release-5.0 #53024

Merged

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Feb 28, 2023

Cherry-pick PR microsoft#53012 into release-5.0

25829eb

Component commits: 2983c85 Omit intersection property check when source includes target f8eea3a Accept new baselines

DanielRosenwasser pushed a commit that referenced this pull request Mar 2, 2023

🤖 Pick PR #53012 (Omit intersection property check wh...) into releas…

3ede924

…e-5.0 (#53024) Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

jakebailey mentioned this pull request Mar 18, 2023

tsserver and intellisense hang indefinitely on "loading intellisense status" and "loading..." when using assertion function and complex conditional type #51188

Closed

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Conversation

ahejlsberg commented Feb 28, 2023

Uh oh!

ahejlsberg commented Feb 28, 2023

Uh oh!

ahejlsberg commented Feb 28, 2023

Uh oh!

typescript-bot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 28, 2023

Uh oh!

typescript-bot commented Feb 28, 2023

Uh oh!

jakebailey commented Feb 28, 2023

Uh oh!

typescript-bot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 28, 2023

Uh oh!

typescript-bot commented Feb 28, 2023

Compiler

TSServer

Startup

Uh oh!

DanielRosenwasser commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahejlsberg commented Feb 28, 2023

Uh oh!

jakebailey commented Feb 28, 2023

Uh oh!

typescript-bot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typescript-bot commented Feb 28, 2023 •

edited

Loading

typescript-bot commented Feb 28, 2023 •

edited

Loading

typescript-bot commented Feb 28, 2023 •

edited

Loading

typescript-bot commented Feb 28, 2023 •

edited

Loading

typescript-bot commented Feb 28, 2023 •

edited

Loading

typescript-bot commented Feb 28, 2023 •

edited

Loading

DanielRosenwasser commented Feb 28, 2023 •

edited

Loading

typescript-bot commented Feb 28, 2023 •

edited

Loading