Exclude completions of binding pattern variable initializers#52723
Merged
sandersn merged 3 commits intomicrosoft:mainfrom Apr 2, 2025
Merged
Exclude completions of binding pattern variable initializers#52723sandersn merged 3 commits intomicrosoft:mainfrom
sandersn merged 3 commits intomicrosoft:mainfrom
Conversation
af52d4c to
c4d73a0
Compare
sandersn
approved these changes
Apr 2, 2025
Member
well this is annoying |
jakebailey
approved these changes
Apr 2, 2025
Contributor
Author
|
Thank you! You are the best! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53049
Real world case:
Some kind of follow up for #42087
Decided to build on top of #52690 (so there is no conflicts if gets merged)
For now will wait until that PR is merged.