Do not resolve apparent type of mapped types with a tuple constraint by Andarist · Pull Request #52651 · microsoft/TypeScript

Andarist · 2023-02-07T09:20:54Z

jakebailey · 2023-02-07T09:27:08Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2023-02-07T09:27:12Z

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at be33c06. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-07T09:27:12Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at be33c06. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-07T09:27:12Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at be33c06. You can monitor the build here.

typescript-bot · 2023-02-07T09:27:12Z

Heya @jakebailey, I've started to run the perf test suite on this PR at be33c06. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-07T09:27:12Z

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at be33c06. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-07T09:27:12Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at be33c06. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-07T09:27:12Z

Heya @jakebailey, I've started to run the extended test suite on this PR at be33c06. You can monitor the build here.

typescript-bot · 2023-02-07T09:39:09Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52651/merge:

Everything looks good!

typescript-bot · 2023-02-07T09:39:20Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52651/merge:

Everything looks good!

typescript-bot · 2023-02-07T09:41:49Z

Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

typescript-bot · 2023-02-07T10:32:21Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52651

_Metric	_main	₅₂₆₅₁	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{359,797k (± 0.02%)}	_{359,805k (± 0.02%)}	_~	_359,726k	_359,907k	_{p=1.000 n=6}
_{Parse Time}	_{3.93s (± 0.90%)}	_{3.94s (± 1.30%)}	_~	_3.86s	_4.00s	_{p=0.687 n=6}
_{Bind Time}	_{1.17s (± 0.64%)}	_{1.18s (± 0.44%)}	_{+0.01s (+ 1.00%)}	_1.18s	_1.19s	_{p=0.020 n=6}
_{Check Time}	_{8.71s (± 0.72%)}	_{8.70s (± 0.44%)}	_~	_8.63s	_8.74s	_{p=0.810 n=6}
_{Emit Time}	_{7.61s (± 0.87%)}	_{7.60s (± 0.52%)}	_~	_7.55s	_7.67s	_{p=0.808 n=6}
_{Total Time}	_{21.42s (± 0.68%)}	_{21.42s (± 0.24%)}	_~	_21.33s	_21.48s	_{p=0.629 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{193,220k (± 1.19%)}	_{195,050k (± 1.55%)}	_~	_192,216k	_197,982k	_{p=0.378 n=6}
_{Parse Time}	_{1.63s (± 1.32%)}	_{1.62s (± 1.63%)}	_~	_1.59s	_1.65s	_{p=0.220 n=6}
_{Bind Time}	_{0.80s (± 0.65%)}	_{0.80s (± 0.51%)}	_~	_0.80s	_0.81s	_{p=0.114 n=6}
_{Check Time}	_{9.75s (± 0.52%)}	_{9.75s (± 0.84%)}	_~	_9.69s	_9.91s	_{p=0.936 n=6}
_{Emit Time}	_{2.80s (± 1.01%)}	_{2.87s (± 4.68%)}	_~	_2.78s	_3.14s	_{p=0.197 n=6}
_{Total Time}	_{14.98s (± 0.46%)}	_{15.04s (± 0.98%)}	_~	_14.89s	_15.30s	_{p=0.422 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{343,965k (± 0.01%)}	_{343,958k (± 0.02%)}	_~	_343,865k	_344,050k	_{p=0.810 n=6}
_{Parse Time}	_{2.94s (± 0.84%)}	_{2.94s (± 0.88%)}	_~	_2.89s	_2.96s	_{p=1.000 n=6}
_{Bind Time}	_{1.04s (± 1.32%)}	_{1.04s (± 1.12%)}	_~	_1.03s	_1.06s	_{p=0.506 n=6}
_{Check Time}	_{7.07s (± 0.47%)}	_{7.04s (± 0.50%)}	_~	_7.02s	_7.11s	_{p=0.126 n=6}
_{Emit Time}	_{4.33s (± 1.22%)}	_{4.32s (± 0.53%)}	_~	_4.30s	_4.36s	_{p=0.573 n=6}
_{Total Time}	_{15.37s (± 0.45%)}	_{15.34s (± 0.40%)}	_~	_15.25s	_15.41s	_{p=0.374 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,377k (± 0.01%)}	_{300,362k (± 0.01%)}	_~	_300,336k	_300,392k	_{p=0.298 n=6}
_{Parse Time}	_{2.27s (± 1.71%)}	_{2.27s (± 1.84%)}	_~	_2.20s	_2.32s	_{p=1.000 n=6}
_{Bind Time}	_{1.17s (± 0.44%)}	_{1.18s (± 0.64%)}	_{+0.01s (+ 1.00%)}	_1.17s	_1.19s	_{p=0.020 n=6}
_{Check Time}	_{6.54s (± 0.65%)}	_{6.55s (± 0.66%)}	_~	_6.51s	_6.63s	_{p=1.000 n=6}
_{Emit Time}	_{3.93s (± 1.01%)}	_{3.93s (± 0.75%)}	_~	_3.90s	_3.96s	_{p=1.000 n=6}
_{Total Time}	_{13.92s (± 0.51%)}	_{13.93s (± 0.49%)}	_~	_13.84s	_14.03s	_{p=0.936 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{476,782k (± 0.01%)}	_{476,787k (± 0.00%)}	_~	_476,760k	_476,822k	_{p=0.810 n=6}
_{Parse Time}	_{3.53s (± 0.46%)}	_{3.52s (± 0.62%)}	_~	_3.50s	_3.56s	_{p=0.406 n=6}
_{Bind Time}	_{0.97s (± 0.53%)}	_{0.97s (± 0.78%)}	_~	_0.96s	_0.98s	_{p=0.784 n=6}
_{Check Time}	_{17.12s (± 0.55%)}	_{17.20s (± 0.42%)}	_~	_17.10s	_17.26s	_{p=0.126 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.61s (± 0.38%)}	_{21.68s (± 0.39%)}	_~	_21.57s	_21.76s	_{p=0.227 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{549,092k (± 0.03%)}	_{549,137k (± 0.02%)}	_~	_548,872k	_549,224k	_{p=0.575 n=6}
_{Parse Time}	_{4.58s (± 0.67%)}	_{4.58s (± 0.69%)}	_~	_4.52s	_4.61s	_{p=0.629 n=6}
_{Bind Time}	_{1.71s (± 1.26%)}	_{1.71s (± 0.57%)}	_~	_1.69s	_1.72s	_{p=0.864 n=6}
_{Check Time}	_{2.81s (± 0.54%)}	_{2.82s (± 0.39%)}	_~	_2.80s	_2.83s	_{p=0.415 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{9.20s (± 0.25%)}	_{9.19s (± 0.36%)}	_~	_9.13s	_9.22s	_{p=0.747 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{359,144k (± 0.01%)}	_{359,159k (± 0.00%)}	_~	_359,146k	_359,175k	_{p=0.199 n=6}
_{Parse Time}	_{4.17s (± 0.45%)}	_{4.18s (± 0.61%)}	_~	_4.16s	_4.23s	_{p=0.222 n=6}
_{Bind Time}	_{1.24s (± 0.41%)}	_{1.23s (± 0.33%)}	_{-0.01s (- 0.94%)}	_1.23s	_1.24s	_{p=0.007 n=6}
_{Check Time}	_{9.49s (± 0.19%)}	_{9.49s (± 0.52%)}	_~	_9.40s	_9.55s	_{p=0.745 n=6}
_{Emit Time}	_{8.06s (± 0.35%)}	_{8.05s (± 0.37%)}	_~	_8.01s	_8.09s	_{p=0.739 n=6}
_{Total Time}	_{22.96s (± 0.23%)}	_{22.96s (± 0.29%)}	_~	_22.89s	_23.04s	_{p=1.000 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,814k (± 0.04%)}	_{193,887k (± 0.05%)}	_~	_193,780k	_194,016k	_{p=0.109 n=6}
_{Parse Time}	_{1.80s (± 0.93%)}	_{1.81s (± 0.42%)}	_~	_1.80s	_1.82s	_{p=0.155 n=6}
_{Bind Time}	_{0.84s (± 0.00%)}	_{0.84s (± 0.61%)}	_~	_0.84s	_0.85s	_{p=0.174 n=6}
_{Check Time}	_{10.42s (± 0.35%)}	_{10.49s (± 0.44%)}	_{+0.07s (+ 0.62%)}	_10.43s	_10.54s	_{p=0.035 n=6}
_{Emit Time}	_{3.10s (± 4.70%)}	_{3.06s (± 0.80%)}	_~	_3.03s	_3.10s	_{p=0.747 n=6}
_{Total Time}	_{16.17s (± 1.07%)}	_{16.20s (± 0.33%)}	_~	_16.13s	_16.25s	_{p=0.229 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,232k (± 0.01%)}	_{343,219k (± 0.01%)}	_~	_343,189k	_343,268k	_{p=0.748 n=6}
_{Parse Time}	_{3.14s (± 1.50%)}	_{3.13s (± 1.08%)}	_~	_3.10s	_3.19s	_{p=0.746 n=6}
_{Bind Time}	_{1.11s (± 1.51%)}	_{1.11s (± 0.46%)}	_~	_1.11s	_1.12s	_{p=0.928 n=6}
_{Check Time}	_{7.73s (± 0.25%)}	_{7.74s (± 0.58%)}	_~	_7.68s	_7.80s	_{p=0.629 n=6}
_{Emit Time}	_{4.54s (± 0.46%)}	_{4.51s (± 0.87%)}	_~	_4.46s	_4.56s	_{p=0.466 n=6}
_{Total Time}	_{16.51s (± 0.50%)}	_{16.50s (± 0.68%)}	_~	_16.34s	_16.66s	_{p=0.687 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,706k (± 0.01%)}	_{299,711k (± 0.01%)}	_~	_299,678k	_299,745k	_{p=0.936 n=6}
_{Parse Time}	_{2.46s (± 0.99%)}	_{2.45s (± 0.83%)}	_~	_2.42s	_2.47s	_{p=0.570 n=6}
_{Bind Time}	_{1.26s (± 0.82%)}	_{1.25s (± 0.67%)}	_~	_1.24s	_1.26s	_{p=0.788 n=6}
_{Check Time}	_{7.21s (± 0.39%)}	_{7.20s (± 0.31%)}	_~	_7.16s	_7.22s	_{p=0.226 n=6}
_{Emit Time}	_{4.22s (± 0.21%)}	_{4.24s (± 0.80%)}	_~	_4.21s	_4.30s	_{p=0.363 n=6}
_{Total Time}	_{15.15s (± 0.23%)}	_{15.14s (± 0.32%)}	_~	_15.08s	_15.19s	_{p=0.686 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,012k (± 0.01%)}	_{476,025k (± 0.00%)}	_~	_475,999k	_476,065k	_{p=0.575 n=6}
_{Parse Time}	_{3.68s (± 0.14%)}	_{3.67s (± 0.76%)}	_~	_3.62s	_3.70s	_{p=1.000 n=6}
_{Bind Time}	_{1.02s (± 0.40%)}	_{1.02s (± 0.40%)}	_~	_1.02s	_1.03s	_{p=0.218 n=6}
_{Check Time}	_{18.21s (± 0.67%)}	_{18.23s (± 0.44%)}	_~	_18.12s	_18.35s	_{p=0.575 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.91s (± 0.54%)}	_{22.92s (± 0.34%)}	_~	_22.85s	_23.06s	_{p=0.630 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{546,665k (± 0.01%)}	_{546,643k (± 0.01%)}	_~	_546,558k	_546,746k	_{p=0.575 n=6}
_{Parse Time}	_{4.77s (± 0.22%)}	_{4.78s (± 0.60%)}	_~	_4.75s	_4.83s	_{p=0.224 n=6}
_{Bind Time}	_{1.84s (± 0.28%)}	_{1.86s (± 0.44%)}	_{+0.01s (+ 0.72%)}	_1.85s	_1.87s	_{p=0.014 n=6}
_{Check Time}	_{3.06s (± 0.65%)}	_{3.06s (± 0.76%)}	_~	_3.03s	_3.08s	_{p=0.669 n=6}
_{Emit Time}	_{0.09s (± 4.45%)}	_{0.09s (± 4.45%)}	_~	_0.09s	_0.10s	_{p=1.000 n=6}
_{Total Time}	_{9.76s (± 0.29%)}	_{9.80s (± 0.36%)}	_~	_9.74s	_9.84s	_{p=0.093 n=6}
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{352,818k (± 0.01%)}	_{352,771k (± 0.03%)}	_~	_352,540k	_352,848k	_{p=0.810 n=6}
_{Parse Time}	_{4.23s (± 0.35%)}	_{4.22s (± 0.45%)}	_~	_4.20s	_4.25s	_{p=0.417 n=6}
_{Bind Time}	_{1.28s (± 0.80%)}	_{1.28s (± 0.85%)}	_~	_1.26s	_1.29s	_{p=0.863 n=6}
_{Check Time}	_{9.74s (± 0.71%)}	_{9.75s (± 0.53%)}	_~	_9.69s	_9.82s	_{p=0.872 n=6}
_{Emit Time}	_{8.37s (± 0.54%)}	_{8.49s (± 2.94%)}	_~	_8.32s	_8.99s	_{p=0.259 n=6}
_{Total Time}	_{23.61s (± 0.42%)}	_{23.73s (± 1.00%)}	_~	_23.52s	_24.17s	_{p=0.471 n=6}
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{188,784k (± 0.05%)}	_{188,775k (± 0.05%)}	_~	_188,697k	_188,969k	_{p=0.689 n=6}
_{Parse Time}	_{1.83s (± 0.41%)}	_{1.83s (± 0.82%)}	_~	_1.82s	_1.86s	_{p=0.933 n=6}
_{Bind Time}	_{0.87s (± 0.97%)}	_{0.87s (± 0.63%)}	_~	_0.86s	_0.87s	_{p=0.855 n=6}
_{Check Time}	_{10.50s (± 0.59%)}	_{10.54s (± 0.56%)}	_~	_10.44s	_10.62s	_{p=0.377 n=6}
_{Emit Time}	_{3.39s (± 3.89%)}	_{3.42s (± 4.16%)}	_~	_3.13s	_3.50s	_{p=0.374 n=6}
_{Total Time}	_{16.59s (± 1.03%)}	_{16.65s (± 0.90%)}	_~	_16.39s	_16.83s	_{p=0.688 n=6}
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{337,993k (± 0.00%)}	_{337,986k (± 0.01%)}	_~	_337,954k	_338,013k	_{p=0.689 n=6}
_{Parse Time}	_{3.20s (± 0.67%)}	_{3.20s (± 0.70%)}	_~	_3.17s	_3.23s	_{p=1.000 n=6}
_{Bind Time}	_{1.11s (± 0.46%)}	_{1.12s (± 0.49%)}	_~	_1.11s	_1.12s	_{p=0.640 n=6}
_{Check Time}	_{8.11s (± 0.56%)}	_{8.09s (± 0.57%)}	_~	_8.02s	_8.12s	_{p=0.125 n=6}
_{Emit Time}	_{4.80s (± 0.83%)}	_{4.77s (± 0.44%)}	_~	_4.75s	_4.80s	_{p=0.106 n=6}
_{Total Time}	_{17.23s (± 0.34%)}	_{17.17s (± 0.48%)}	_~	_17.06s	_17.25s	_{p=0.423 n=6}
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{294,575k (± 0.01%)}	_{294,567k (± 0.01%)}	_~	_294,545k	_294,595k	_{p=0.521 n=6}
_{Parse Time}	_{2.74s (± 0.68%)}	_{2.74s (± 0.30%)}	_~	_2.73s	_2.75s	_{p=0.459 n=6}
_{Bind Time}	_{1.11s (± 0.95%)}	_{1.11s (± 0.37%)}	_~	_1.11s	_1.12s	_{p=0.209 n=6}
_{Check Time}	_{7.51s (± 0.47%)}	_{7.55s (± 0.43%)}	_~	_7.51s	_7.61s	_{p=0.090 n=6}
_{Emit Time}	_{4.63s (± 1.03%)}	_{4.66s (± 0.53%)}	_~	_4.63s	_4.69s	_{p=0.291 n=6}
_{Total Time}	_{15.99s (± 0.44%)}	_{16.06s (± 0.21%)}	_~	_16.01s	_16.10s	_{p=0.109 n=6}
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{471,622k (± 0.00%)}	_{471,616k (± 0.01%)}	_~	_471,561k	_471,649k	_{p=0.810 n=6}
_{Parse Time}	_{3.88s (± 0.72%)}	_{3.86s (± 0.56%)}	_~	_3.83s	_3.89s	_{p=0.223 n=6}
_{Bind Time}	_{1.05s (± 0.00%)}	_{1.05s (± 0.49%)}	_~	_1.04s	_1.05s	_{p=0.174 n=6}
_{Check Time}	_{19.14s (± 0.77%)}	_{19.19s (± 0.82%)}	_~	_18.96s	_19.43s	_{p=0.575 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{24.07s (± 0.57%)}	_{24.10s (± 0.72%)}	_~	_23.86s	_24.36s	_{p=0.689 n=6}
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{534,749k (± 0.00%)}	_{534,722k (± 0.01%)}	_~	_534,656k	_534,758k	_{p=0.261 n=6}
_{Parse Time}	_{5.12s (± 0.82%)}	_{5.12s (± 0.52%)}	_~	_5.10s	_5.16s	_{p=1.000 n=6}
_{Bind Time}	_{1.71s (± 0.60%)}	_{1.71s (± 0.68%)}	_~	_1.69s	_1.72s	_{p=0.801 n=6}
_{Check Time}	_{3.13s (± 0.48%)}	_{3.14s (± 0.51%)}	_~	_3.12s	_3.16s	_{p=0.285 n=6}
_{Emit Time}	_{0.10s (± 4.01%)}	_{0.10s (± 0.00%)}	_~	_0.10s	_0.10s	_{p=0.405 n=6}
_{Total Time}	_{10.06s (± 0.36%)}	_{10.08s (± 0.33%)}	_~	_10.03s	_10.12s	_{p=0.520 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₆₅₁	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..52651

_Metric	_main	₅₂₆₅₁	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,496ms (± 1.28%)}	_{2,519ms (± 1.79%)}	_~	_2,467ms	_2,587ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{5,511ms (± 0.57%)}	_{5,592ms (± 0.41%)}	_{+82ms (+ 1.48%)}	_5,564ms	_5,622ms	_{p=0.005 n=6}
_{Req 3 - references}	_{370ms (± 1.13%)}	_{367ms (± 0.79%)}	_~	_364ms	_371ms	_{p=0.293 n=6}
_{Req 4 - navto}	_{284ms (± 0.99%)}	_{285ms (± 0.56%)}	_~	_283ms	_287ms	_{p=0.629 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{73ms (± 1.03%)}	_{73ms (± 1.94%)}	_~	_71ms	_75ms	_{p=0.867 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,739ms (± 0.79%)}	_{2,748ms (± 0.67%)}	_~	_2,714ms	_2,768ms	_{p=0.873 n=6}
_{Req 2 - geterr}	_{4,059ms (± 0.64%)}	_{4,058ms (± 0.37%)}	_~	_4,040ms	_4,076ms	_{p=0.575 n=6}
_{Req 3 - references}	_{368ms (± 0.72%)}	_{367ms (± 1.45%)}	_~	_359ms	_374ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{293ms (± 0.88%)}	_{294ms (± 0.76%)}	_~	_292ms	_298ms	_{p=0.871 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{66ms (± 0.79%)}	_{66ms (± 1.48%)}	_~	_65ms	_67ms	_{p=0.348 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,490ms (± 0.82%)}	_{3,495ms (± 0.53%)}	_~	_3,476ms	_3,518ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{1,648ms (± 0.66%)}	_{1,653ms (± 0.73%)}	_~	_1,635ms	_1,668ms	_{p=0.261 n=6}
_{Req 3 - references}	_{104ms (± 1.05%)}	_{105ms (± 1.40%)}	_~	_103ms	_106ms	_{p=0.403 n=6}
_{Req 4 - navto}	_{355ms (± 0.53%)}	_{356ms (± 1.22%)}	_~	_353ms	_364ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{3,175 (± 0.00%)}	_{3,175 (± 0.00%)}	_~	_3,175	_3,175	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{450ms (± 0.90%)}	_{447ms (± 1.72%)}	_~	_433ms	_454ms	_{p=0.572 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,770ms (± 0.58%)}	_{2,764ms (± 0.49%)}	_~	_2,744ms	_2,778ms	_{p=0.423 n=6}
_{Req 2 - geterr}	_{5,930ms (± 0.53%)}	_{5,929ms (± 0.64%)}	_~	_5,878ms	_5,991ms	_{p=0.810 n=6}
_{Req 3 - references}	_{377ms (± 0.76%)}	_{375ms (± 0.90%)}	_~	_370ms	_378ms	_{p=0.220 n=6}
_{Req 4 - navto}	_{277ms (± 0.91%)}	_{279ms (± 0.64%)}	_~	_276ms	_281ms	_{p=0.142 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 2.70%)}	_{82ms (± 4.45%)}	_~	_77ms	_85ms	_{p=0.195 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,924ms (± 0.37%)}	_{2,915ms (± 0.57%)}	_~	_2,897ms	_2,940ms	_{p=0.378 n=6}
_{Req 2 - geterr}	_{4,412ms (± 0.53%)}	_{4,405ms (± 0.47%)}	_~	_4,386ms	_4,441ms	_{p=0.873 n=6}
_{Req 3 - references}	_{382ms (± 1.07%)}	_{380ms (± 1.10%)}	_~	_375ms	_386ms	_{p=0.519 n=6}
_{Req 4 - navto}	_{287ms (± 0.56%)}	_{287ms (± 0.60%)}	_~	_284ms	_289ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{71ms (± 0.57%)}	_{71ms (± 0.00%)}	_~	_71ms	_71ms	_{p=0.405 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,626ms (± 0.35%)}	_{3,630ms (± 0.51%)}	_~	_3,597ms	_3,647ms	_{p=0.471 n=6}
_{Req 2 - geterr}	_{1,825ms (± 1.51%)}	_{1,810ms (± 0.99%)}	_~	_1,785ms	_1,837ms	_{p=0.377 n=6}
_{Req 3 - references}	_{113ms (± 1.42%)}	_{112ms (± 1.49%)}	_~	_109ms	_113ms	_{p=0.277 n=6}
_{Req 4 - navto}	_{344ms (± 1.02%)}	_{344ms (± 1.36%)}	_~	_337ms	_350ms	_{p=0.868 n=6}
_{Req 5 - completionInfo count}	_{3,175 (± 0.00%)}	_{3,175 (± 0.00%)}	_~	_3,175	_3,175	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{457ms (± 0.99%)}	_{457ms (± 0.97%)}	_~	_452ms	_463ms	_{p=0.627 n=6}
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,884ms (± 0.28%)}	_{2,884ms (± 0.29%)}	_~	_2,874ms	_2,895ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{6,277ms (± 0.73%)}	_{6,331ms (± 0.74%)}	_~	_6,260ms	_6,399ms	_{p=0.066 n=6}
_{Req 3 - references}	_{391ms (± 0.53%)}	_{391ms (± 0.95%)}	_~	_386ms	_396ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{280ms (± 1.31%)}	_{288ms (± 2.25%)}	_{+7ms (+ 2.56%)}	_279ms	_298ms	_{p=0.044 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{99ms (± 1.69%)}	_{90ms (± 9.83%)}	_~	_80ms	_100ms	_{p=0.167 n=6}
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,038ms (± 0.96%)}	_{3,046ms (± 0.62%)}	_~	_3,031ms	_3,082ms	_{p=0.376 n=6}
_{Req 2 - geterr}	_{4,695ms (± 0.40%)}	_{4,709ms (± 0.44%)}	_~	_4,682ms	_4,736ms	_{p=0.336 n=6}
_{Req 3 - references}	_{404ms (± 0.43%)}	_{403ms (± 0.66%)}	_~	_400ms	_408ms	_{p=0.293 n=6}
_{Req 4 - navto}	_{293ms (± 1.30%)}	_{294ms (± 1.27%)}	_~	_289ms	_299ms	_{p=0.624 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (± 3.84%)}	_{82ms (± 3.84%)}	_~	_80ms	_88ms	_{p=1.000 n=6}
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,955ms (± 0.60%)}	_{3,945ms (± 0.46%)}	_~	_3,927ms	_3,970ms	_{p=0.378 n=6}
_{Req 2 - geterr}	_{1,776ms (± 1.68%)}	_{1,822ms (± 1.74%)}	_{+45ms (+ 2.55%)}	_1,785ms	_1,856ms	_{p=0.020 n=6}
_{Req 3 - references}	_{133ms (± 1.99%)}	_{130ms (± 3.34%)}	_~	_124ms	_135ms	_{p=0.075 n=6}
_{Req 4 - navto}	_{375ms (± 0.95%)}	_{375ms (± 0.54%)}	_~	_372ms	_378ms	_{p=0.745 n=6}
_{Req 5 - completionInfo count}	_{3,175 (± 0.00%)}	_{3,175 (± 0.00%)}	_~	_3,175	_3,175	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{470ms (± 2.40%)}	_{471ms (± 2.13%)}	_~	_457ms	_480ms	_{p=0.810 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₆₅₁	₆
_Baseline	_main	₆

Startup

Comparison Report - main..52651

_Metric	_main	₅₂₆₅₁	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{142.53ms (± 0.21%)}	_{142.82ms (± 0.20%)}	_{+0.30ms (+ 0.21%)}	_141.85ms	_147.47ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{227.47ms (± 0.18%)}	_{231.85ms (± 0.35%)}	_{+4.39ms (+ 1.93%)}	_226.75ms	_238.12ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{228.98ms (± 0.13%)}	_{233.36ms (± 0.18%)}	_{+4.38ms (+ 1.91%)}	_229.89ms	_239.09ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{209.74ms (± 0.15%)}	_{211.88ms (± 0.38%)}	_{+2.14ms (+ 1.02%)}	_208.73ms	_218.01ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₆₅₁	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-02-07T11:23:50Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52651/merge:

Something interesting changed - please have a look.

Details

backstage/backstage

Server exited prematurely with code unknown and signal SIGABRT

That is a filtered view of the text. To see the raw error text, go to RepoResults4/backstage.backstage.rawError.txt in the artifact folder

Last few requests

{"seq":6466,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/plugins/catalog-backend/src/database/DefaultProviderDatabase.test.ts","line":335,"offset":22}}
{"seq":6467,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/plugins/catalog-backend/src/database/DefaultProviderDatabase.test.ts","line":400,"offset":25,"includeExternalModuleExports":false,"triggerKind":1}}
{"seq":6468,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/plugins/catalog-backend/src/database/DefaultProviderDatabase.test.ts","line":400,"offset":25,"entryNames":["applyDatabaseMigrations"]}}
{"seq":6469,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/plugins/catalog-backend/src/database/DefaultProviderDatabase.test.ts","line":580,"offset":35}}

Repro Steps

git clone https://github.com/backstage/backstage --recurse-submodules
In dir backstage, run git reset --hard 2db93700fe9cc19a7db4f0711544b0c189aefeba
Install packages (exact steps are below, but it might be easier to follow the repo readme)
1. In dir backstage/cypress, run yarn install --no-immutable --mode=skip-build
2. In dir backstage/microsite-next, run yarn install --no-immutable --mode=skip-build
3. In dir backstage/microsite, run yarn install --no-immutable --mode=skip-build
4. In dir backstage, run yarn install --no-immutable --mode=skip-build
5. In dir backstage/storybook, run yarn install --no-immutable --mode=skip-build
Back in the initial folder, download RepoResults4/backstage.backstage.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./backstage ./backstage.backstage.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

codex-team/editor.js

⚠️ Note that built also had errors ⚠️

Req #4391 - completionInfo
    at Object.addImportFromExportedSymbol (/typescript-main/built/local/tsserver.js:140793:13)
    at /typescript-main/built/local/tsserver.js:146513:38
    at importSymbols (/typescript-main/built/local/tsserver.js:146513:11)
    at Object.addNewNodeForMemberSymbol (/typescript-main/built/local/tsserver.js:145946:11)
    at getEntryForMemberCompletion (/typescript-main/built/local/tsserver.js:148372:22)
    at createCompletionEntry (/typescript-main/built/local/tsserver.js:148269:64)
    at getCompletionEntriesFromSymbols (/typescript-main/built/local/tsserver.js:148808:19)
    at completionInfoFromData (/typescript-main/built/local/tsserver.js:147936:23)
    at Object.getCompletionsAtPosition (/typescript-main/built/local/tsserver.js:147758:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-main/built/local/tsserver.js:134880:35)
    at IOSession.getCompletions (/typescript-main/built/local/tsserver.js:178378:54)
    at completionInfo (/typescript-main/built/local/tsserver.js:176789:43)
    at /typescript-main/built/local/tsserver.js:179142:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:179134:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:179142:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:179184:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:180728:14)

Req #4391 - completionInfo
    at Object.addImportFromExportedSymbol (/typescript-52651/built/local/tsserver.js:140793:13)
    at /typescript-52651/built/local/tsserver.js:146513:38
    at importSymbols (/typescript-52651/built/local/tsserver.js:146513:11)
    at Object.addNewNodeForMemberSymbol (/typescript-52651/built/local/tsserver.js:145946:11)
    at getEntryForMemberCompletion (/typescript-52651/built/local/tsserver.js:148372:22)
    at createCompletionEntry (/typescript-52651/built/local/tsserver.js:148269:64)
    at getCompletionEntriesFromSymbols (/typescript-52651/built/local/tsserver.js:148808:19)
    at completionInfoFromData (/typescript-52651/built/local/tsserver.js:147936:23)
    at Object.getCompletionsAtPosition (/typescript-52651/built/local/tsserver.js:147758:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-52651/built/local/tsserver.js:134880:35)
    at IOSession.getCompletions (/typescript-52651/built/local/tsserver.js:178378:54)
    at completionInfo (/typescript-52651/built/local/tsserver.js:176789:43)
    at /typescript-52651/built/local/tsserver.js:179142:69
    at IOSession.executeWithRequestId (/typescript-52651/built/local/tsserver.js:179134:14)
    at IOSession.executeCommand (/typescript-52651/built/local/tsserver.js:179142:29)
    at IOSession.onMessage (/typescript-52651/built/local/tsserver.js:179184:51)
    at Interface.<anonymous> (/typescript-52651/built/local/tsserver.js:180728:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/codex-team.editor.js.rawError.txt in the artifact folder

Last few requests

{"seq":4388,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/toolbar/inline.ts","line":331,"offset":1,"entryNames":["_"]}}
{"seq":4389,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/toolbar/inline.ts","line":391,"offset":14,"includeExternalModuleExports":false,"triggerKind":1}}
{"seq":4390,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/toolbar/inline.ts","line":391,"offset":14,"entryNames":["_"]}}
{"seq":4391,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/toolbar/inline.ts","line":425,"offset":1,"includeExternalModuleExports":false,"triggerKind":1}}

Repro Steps

git clone https://github.com/codex-team/editor.js --recurse-submodules
In dir editor.js, run git reset --hard 551e3f10b92cf5f5bb4fbd95ac504a815526dc18
Install packages (exact steps are below, but it might be easier to follow the repo readme)
1. In dir editor.js/example/tools/checklist, run yarn install --ignore-engines --ignore-scripts --silent
2. In dir editor.js/example/tools/code, run yarn install --ignore-engines --ignore-scripts --silent
3. In dir editor.js/example/tools/delimiter, run yarn install --ignore-engines --ignore-scripts --silent
4. In dir editor.js/example/tools/embed, run yarn install --ignore-engines --ignore-scripts --silent
5. In dir editor.js/example/tools/header, run yarn install --ignore-engines --ignore-scripts --silent
6. In dir editor.js/example/tools/image, run yarn install --ignore-engines --ignore-scripts --silent
7. In dir editor.js/example/tools/inline-code, run yarn install --ignore-engines --ignore-scripts --silent
8. In dir editor.js/example/tools/link, run yarn install --ignore-engines --ignore-scripts --silent
9. In dir editor.js/example/tools/list, run yarn install --ignore-engines --ignore-scripts --silent
10. In dir editor.js/example/tools/marker, run yarn install --ignore-engines --ignore-scripts --silent
11. In dir editor.js/example/tools/nested-list, run yarn install --ignore-engines --ignore-scripts --silent
12. In dir editor.js/example/tools/quote, run yarn install --ignore-engines --ignore-scripts --silent
13. In dir editor.js/example/tools/raw, run yarn install --ignore-engines --ignore-scripts --silent
14. In dir editor.js/example/tools/simple-image, run yarn install --ignore-engines --ignore-scripts --silent
15. In dir editor.js/example/tools/table, run yarn install --ignore-engines --ignore-scripts --silent
16. In dir editor.js/example/tools/text-variant-tune, run yarn install --ignore-engines --ignore-scripts --silent
17. In dir editor.js/example/tools/warning, run yarn install --ignore-engines --ignore-scripts --silent
18. In dir editor.js, run yarn install --ignore-engines --ignore-scripts --silent
19. In dir editor.js/src/tools/paragraph, run yarn install --ignore-engines --ignore-scripts --silent
Back in the initial folder, download RepoResults4/codex-team.editor.js.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./editor.js ./codex-team.editor.js.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

typeorm/typeorm

⚠️ Note that built also had errors ⚠️

Req #2194 - completionInfo
    at consumeTokenAndAdvanceScanner (/typescript-main/built/local/tsserver.js:165944:13)
    at processChildNode (/typescript-main/built/local/tsserver.js:165853:9)
    at /typescript-main/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29284:18)
    at forEachChildInMappedType (/typescript-main/built/local/tsserver.js:29427:133)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at /typescript-main/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29284:18)
    at forEachChildInArrayType (/typescript-main/built/local/tsserver.js:29402:12)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at /typescript-main/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29284:18)
    at forEachChildInConditionalType (/typescript-main/built/local/tsserver.js:29410:90)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at /typescript-main/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29284:18)
    at forEachChildInParenthesizedTypeOrTypeOperator (/typescript-main/built/local/tsserver.js:29748:10)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at processChildNodes (/typescript-main/built/local/tsserver.js:165911:32)
    at /typescript-main/built/local/tsserver.js:165805:9
    at visitNodes (/typescript-main/built/local/tsserver.js:29289:14)
    at forEachChildInUnionOrIntersectionType (/typescript-main/built/local/tsserver.js:29745:10)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at /typescript-main/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29284:18)
    at forEachChildInMappedType (/typescript-main/built/local/tsserver.js:29427:175)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at processChildNodes (/typescript-main/built/local/tsserver.js:165911:32)
    at /typescript-main/built/local/tsserver.js:165805:9
    at visitNodes (/typescript-main/built/local/tsserver.js:29289:14)
    at forEachChildInUnionOrIntersectionType (/typescript-main/built/local/tsserver.js:29745:10)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at /typescript-main/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29284:18)
    at forEachChildInParameter (/typescript-main/built/local/tsserver.js:29334:177)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165868:7)
    at processChildNodes (/typescript-main/built/local/tsserver.js:165911:32)
    at /typescript-main/built/local/tsserver.js:165805:9
    at visitNodes (/typescript-main/built/local/tsserver.js:29289:14)
    at forEachChildInMethodDeclaration (/typescript-main/built/local/tsserver.js:29363:273)
    at forEachChild (/typescript-main/built/local/tsserver.js:29798:35)
    at processNode (/typescript-main/built/local/tsserver.js:165789:5)
    at formatSpanWorker (/typescript-main/built/local/tsserver.js:165597:5)
    at /typescript-main/built/local/tsserver.js:165537:105
    at getFormattingScanner (/typescript-main/built/local/tsserver.js:164353:15)
    at Object.formatNodeGivenIndentation (/typescript-main/built/local/tsserver.js:165537:10)
    at /typescript-main/built/local/tsserver.js:148640:36
    at flatMap (/typescript-main/built/local/tsserver.js:2556:17)
    at Object.printAndFormatSnippetList (/typescript-main/built/local/tsserver.js:148638:21)
    at getEntryForMemberCompletion (/typescript-main/built/local/tsserver.js:148408:28)
    at createCompletionEntry (/typescript-main/built/local/tsserver.js:148269:64)
    at getCompletionEntriesFromSymbols (/typescript-main/built/local/tsserver.js:148808:19)
    at completionInfoFromData (/typescript-main/built/local/tsserver.js:147936:23)
    at Object.getCompletionsAtPosition (/typescript-main/built/local/tsserver.js:147758:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-main/built/local/tsserver.js:134880:35)
    at IOSession.getCompletions (/typescript-main/built/local/tsserver.js:178378:54)
    at completionInfo (/typescript-main/built/local/tsserver.js:176789:43)
    at /typescript-main/built/local/tsserver.js:179142:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:179134:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:179142:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:179184:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:180728:14)

Req #2194 - completionInfo
    at consumeTokenAndAdvanceScanner (/typescript-52651/built/local/tsserver.js:165944:13)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165853:9)
    at /typescript-52651/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-52651/built/local/tsserver.js:29284:18)
    at forEachChildInMappedType (/typescript-52651/built/local/tsserver.js:29427:133)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at /typescript-52651/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-52651/built/local/tsserver.js:29284:18)
    at forEachChildInArrayType (/typescript-52651/built/local/tsserver.js:29402:12)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at /typescript-52651/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-52651/built/local/tsserver.js:29284:18)
    at forEachChildInConditionalType (/typescript-52651/built/local/tsserver.js:29410:90)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at /typescript-52651/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-52651/built/local/tsserver.js:29284:18)
    at forEachChildInParenthesizedTypeOrTypeOperator (/typescript-52651/built/local/tsserver.js:29748:10)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at processChildNodes (/typescript-52651/built/local/tsserver.js:165911:32)
    at /typescript-52651/built/local/tsserver.js:165805:9
    at visitNodes (/typescript-52651/built/local/tsserver.js:29289:14)
    at forEachChildInUnionOrIntersectionType (/typescript-52651/built/local/tsserver.js:29745:10)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at /typescript-52651/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-52651/built/local/tsserver.js:29284:18)
    at forEachChildInMappedType (/typescript-52651/built/local/tsserver.js:29427:175)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at processChildNodes (/typescript-52651/built/local/tsserver.js:165911:32)
    at /typescript-52651/built/local/tsserver.js:165805:9
    at visitNodes (/typescript-52651/built/local/tsserver.js:29289:14)
    at forEachChildInUnionOrIntersectionType (/typescript-52651/built/local/tsserver.js:29745:10)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at /typescript-52651/built/local/tsserver.js:165792:9
    at visitNode2 (/typescript-52651/built/local/tsserver.js:29284:18)
    at forEachChildInParameter (/typescript-52651/built/local/tsserver.js:29334:177)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at processChildNode (/typescript-52651/built/local/tsserver.js:165868:7)
    at processChildNodes (/typescript-52651/built/local/tsserver.js:165911:32)
    at /typescript-52651/built/local/tsserver.js:165805:9
    at visitNodes (/typescript-52651/built/local/tsserver.js:29289:14)
    at forEachChildInMethodDeclaration (/typescript-52651/built/local/tsserver.js:29363:273)
    at forEachChild (/typescript-52651/built/local/tsserver.js:29798:35)
    at processNode (/typescript-52651/built/local/tsserver.js:165789:5)
    at formatSpanWorker (/typescript-52651/built/local/tsserver.js:165597:5)
    at /typescript-52651/built/local/tsserver.js:165537:105
    at getFormattingScanner (/typescript-52651/built/local/tsserver.js:164353:15)
    at Object.formatNodeGivenIndentation (/typescript-52651/built/local/tsserver.js:165537:10)
    at /typescript-52651/built/local/tsserver.js:148640:36
    at flatMap (/typescript-52651/built/local/tsserver.js:2556:17)
    at Object.printAndFormatSnippetList (/typescript-52651/built/local/tsserver.js:148638:21)
    at getEntryForMemberCompletion (/typescript-52651/built/local/tsserver.js:148408:28)
    at createCompletionEntry (/typescript-52651/built/local/tsserver.js:148269:64)
    at getCompletionEntriesFromSymbols (/typescript-52651/built/local/tsserver.js:148808:19)
    at completionInfoFromData (/typescript-52651/built/local/tsserver.js:147936:23)
    at Object.getCompletionsAtPosition (/typescript-52651/built/local/tsserver.js:147758:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-52651/built/local/tsserver.js:134880:35)
    at IOSession.getCompletions (/typescript-52651/built/local/tsserver.js:178378:54)
    at completionInfo (/typescript-52651/built/local/tsserver.js:176789:43)
    at /typescript-52651/built/local/tsserver.js:179142:69
    at IOSession.executeWithRequestId (/typescript-52651/built/local/tsserver.js:179134:14)
    at IOSession.executeCommand (/typescript-52651/built/local/tsserver.js:179142:29)
    at IOSession.onMessage (/typescript-52651/built/local/tsserver.js:179184:51)
    at Interface.<anonymous> (/typescript-52651/built/local/tsserver.js:180728:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults2/typeorm.typeorm.rawError.txt in the artifact folder

Last few requests

{"seq":2191,"type":"request","command":"organizeImports","arguments":{"scope":{"type":"file","args":{"file":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts"}},"skipDestructiveCodeActions":true}}
{"seq":2192,"type":"request","command":"getOutliningSpans","arguments":{"file":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts"}}
{"seq":2193,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts","line":19,"offset":15}}
{"seq":2194,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts","line":37,"offset":1,"includeExternalModuleExports":false,"triggerKind":1}}

Repro Steps

git clone https://github.com/typeorm/typeorm --recurse-submodules
In dir typeorm, run git reset --hard adce6985d899dac29f174e6c828e3042cbea6bdc
Back in the initial folder, download RepoResults2/typeorm.typeorm.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./typeorm ./typeorm.typeorm.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

typescript-bot · 2023-02-07T11:29:09Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52651/merge:

Everything looks good!

weswigham · 2023-03-14T23:36:15Z

@typescript-bot run dt but new and improved with more response post-backs

typescript-bot · 2023-03-14T23:36:18Z

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at be33c06. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-15T01:32:06Z

Hey @weswigham, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

Andarist · 2023-03-15T06:22:13Z

How can I see those failures?

jakebailey · 2023-03-15T06:25:25Z

It's nothing you did; just a timeout.

@typescript-bot run dt

typescript-bot · 2023-03-15T06:25:29Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at be33c06. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-15T08:27:39Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

weswigham

Since DT says this is good, I'm inclined to take it. Since we just shipped 5.0, we have a full release cycle to see if this has any unintended consequences (though I can't think of any offhand, and obvious our tests don't either). :)

Do not resolve apparent type of mapped types with a tuple constraint

be33c06

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 7, 2023

sandersn requested review from gabritto and weswigham February 28, 2023 21:50

sandersn assigned gabritto Feb 28, 2023

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 28, 2023

weswigham approved these changes Mar 15, 2023

View reviewed changes

weswigham merged commit 074bf34 into microsoft:main Mar 15, 2023

Andarist deleted the fix/dont-resolve-apparent-type-of-types-with-tuple-constraint branch March 15, 2023 17:49

This was referenced Mar 16, 2023

Fixed an issue with not being able to use mapped type over union constraint as rest param #49947

Merged

[NewErrors] 5.1.0-dev.20230319 vs 5.0.2 #53359

Closed

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Conversation

Andarist commented Feb 7, 2023

Uh oh!

jakebailey commented Feb 7, 2023

Uh oh!

typescript-bot commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 7, 2023

Uh oh!

typescript-bot commented Feb 7, 2023

Uh oh!

typescript-bot commented Feb 7, 2023

Uh oh!

typescript-bot commented Feb 7, 2023

Compiler

TSServer

Startup

Uh oh!

typescript-bot commented Feb 7, 2023

backstage/backstage

Last few requests

Repro Steps

codex-team/editor.js

Last few requests

Repro Steps

typeorm/typeorm

Last few requests

Repro Steps

Uh oh!

typescript-bot commented Feb 7, 2023

Uh oh!

weswigham commented Mar 14, 2023

Uh oh!

typescript-bot commented Mar 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 15, 2023

Uh oh!

Andarist commented Mar 15, 2023

Uh oh!

jakebailey commented Mar 15, 2023

Uh oh!

typescript-bot commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Mar 15, 2023

Uh oh!

weswigham left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Feb 7, 2023 •

edited

Loading

typescript-bot commented Mar 14, 2023 •

edited

Loading

typescript-bot commented Mar 15, 2023 •

edited

Loading

weswigham left a comment •

edited

Loading