Fix crash when looking for __esModule during symbol table merging#52554
Merged
andrewbranch merged 1 commit intomicrosoft:mainfrom Feb 2, 2023
Merged
Fix crash when looking for __esModule during symbol table merging#52554andrewbranch merged 1 commit intomicrosoft:mainfrom
__esModule during symbol table merging#52554andrewbranch merged 1 commit intomicrosoft:mainfrom
Conversation
typescript-bot
added
Author: Team
For Milestone Bug
sheetalkamat
reviewed
Feb 2, 2023
| function resolveExportByName(moduleSymbol: Symbol, name: __String, sourceNode: TypeOnlyCompatibleAliasDeclaration | undefined, dontResolveAlias: boolean) { | ||
| const exportValue = moduleSymbol.exports!.get(InternalSymbolName.ExportEquals); | ||
| const exportSymbol = exportValue ? getPropertyOfType(getTypeOfSymbol(exportValue), name) : moduleSymbol.exports!.get(name); | ||
| const exportSymbol = exportValue |
Member
There was a problem hiding this comment.
May be adding a note or something just as a reminder would be good. (that its called for default or __esModule
sheetalkamat
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48701
This is just more of #37964, but for our own lookups of
__esModule. This function is literally only called with"__esModule"andInternalSymbolName.Default, so I can guarantee it doesn’t need to look at the global object type for those.