[experiment] Check for extended empty tuples in isTupleLikeType

[jakebailey]

I want to export this in #52467 but it doesn't work when you write:

type EmptyTuple = []

interface MyEmptyTuple extends EmptyTuple {
	extraInfo: any;
}

Because isTupleLikeType determines tuple-ness by checking for a property named 0 which won't exist on an empty tuple.

I don't think this is the final code but I want to see what this breaks. It seems like there's a lot of code which depends on empty tuples not being handled, and I don't know how much that matters.

[jakebailey]

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 03c06c6. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 03c06c6. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the perf test suite on this PR at 03c06c6. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at 03c06c6. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 03c06c6. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52551/merge:

Something interesting changed - please have a look.

Details

uglify-js

/mnt/ts_downloads/uglify-js/tsconfig.json

• [NEW] error TS2345: Argument of type 'any' is not assignable to parameter of type 'never'.
  • /mnt/ts_downloads/uglify-js/node_modules/uglify-js/lib/scope.js(647,55)
• [NEW] error TS2339: Property 'references' does not exist on type 'never'.
  • /mnt/ts_downloads/uglify-js/node_modules/uglify-js/lib/scope.js(662,41)
  • /mnt/ts_downloads/uglify-js/node_modules/uglify-js/lib/scope.js(662,74)
• [NEW] error TS2322: Type 'never[]' is not assignable to type '[]'.
  • /mnt/ts_downloads/uglify-js/node_modules/uglify-js/lib/scope.js(664,17)

webpack

tsconfig.json

• [NEW] error TS2349: This expression is not callable.
  • lib/Compilation.js#L5049
• [NEW] error TS2345: Argument of type 'string | number' is not assignable to parameter of type 'never'.
  • lib/container/RemoteRuntimeModule.js#L43

tsconfig.types.json

• [NEW] error TS2349: This expression is not callable.
  • lib/Compilation.js#L5049
• [NEW] error TS2345: Argument of type 'string | number' is not assignable to parameter of type 'never'.
  • lib/container/RemoteRuntimeModule.js#L43
• [MISSING] error TS7005: Variable 'interceptModuleExecution' implicitly has an 'any[]' type.
  • lib/Compilation.js#L5017
• [MISSING] error TS7005: Variable 'remotes' implicitly has an 'any[]' type.
  • lib/container/RemoteRuntimeModule.js#L33

[typescript-bot]

Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

[jakebailey]

The above definitely implies this PR is wrong as-is, of course.

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52551/merge:

Something interesting changed - please have a look.

Details

vercel/swr

4 of 11 projects failed to build with the old tsc and were ignored

test/type/tsconfig.json

• error TS2345: Argument of type 'true' is not assignable to parameter of type 'false'.
  • test/type/fetcher.ts#L71
  • test/type/fetcher.ts#L77
  • test/type/fetcher.ts#L88
  • test/type/option-fetcher.ts#L73
  • test/type/option-fetcher.ts#L84
  • test/type/option-fetcher.ts#L95

vuejs/vue

7 of 8 projects failed to build with the old tsc and were ignored

tsconfig.json

• error TS2322: Type '0' is not assignable to type '1'.
  • src/core/vdom/helpers/resolve-async-component.ts#L74
  • src/core/vdom/helpers/resolve-async-component.ts#L94

[jakebailey]

#52617 does this but correctly.