Fixed an issue with spreading a spreadable generic expression into generic JSX#51580
Fixed an issue with spreading a spreadable generic expression into generic JSX#51580weswigham merged 2 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
src/compiler/checker.ts
Outdated
| attributesTable = createSymbolTable(); | ||
| } | ||
| const exprType = getReducedType(checkExpressionCached(attributeDecl.expression, checkMode)); | ||
| const exprType = getReducedType(checkExpressionCached(attributeDecl.expression)); |
There was a problem hiding this comment.
this aligns the logic here for the equivalent call in the checkObjectLiteral:
https://github.dev/microsoft/TypeScript/blob/4ea8ec49e8aed6601fb6b978fd08031ec058da04/src/compiler/checker.ts#L28541
note that neither of those lines were touched recently
tests/baselines/reference/contextuallyTypedStringLiteralsInJsxAttributes02.errors.txt
Outdated
Show resolved
Hide resolved
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
Just want to see some extended suites be green and this looks reasonable to me~
|
@typescript-bot run dt |
|
Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at 1c00498. You can monitor the build here. Update: The results are in! |
|
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 1c00498. You can monitor the build here. Update: The results are in! |
|
@weswigham Here are the results of running the top-repos suite comparing Everything looks good! |
|
Hey @weswigham, the results of running the DT tests are ready. |
|
This PR appears to have broken main via a baseline change. |
… into generic JSX (microsoft#51580)" This reverts commit 63495be.
This reverts commit 7f292bf.
4 participants
fixes #51577