Bind module.export = {Thing} with alias symbols#41287
Merged
weswigham merged 2 commits intomicrosoft:masterfrom Oct 28, 2020
Merged
Bind module.export = {Thing} with alias symbols#41287weswigham merged 2 commits intomicrosoft:masterfrom
module.export = {Thing} with alias symbols#41287weswigham merged 2 commits intomicrosoft:masterfrom
Conversation
sandersn
approved these changes
Oct 27, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Might be nice to run user tests before merging, since the assert moved a little. (Though it looks like it should happen in strictly fewer cases.)
Member
Author
|
@typescript-bot user test this |
Collaborator
|
Heya @weswigham, I've started to run the parallelized community code test suite on this PR at e96ce39. You can monitor the build here. |
Collaborator
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Member
|
Huh, I bet this makes (at least parts of) #40835 obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41250, the last half of it.
This was actually an incredibly small change, thanks to already anticipating aliases like this pretty much everywhere. DO note that in addition to shorthand property references, we could also probably bind
{ Name: EntityName }references as aliases safely, too, though this PR does not add that currently.