🤖 User test baselines have changed for refs/heads/master by typescript-bot · Pull Request #40156 · microsoft/TypeScript

typescript-bot · 2020-08-20T17:06:44Z

This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.

cc @microsoft/typescript

sandersn · 2020-08-21T19:13:06Z

tests/baselines/reference/docker/office-ui-fabric.log

+@uifabric/build: create-package/plop-templates-react/src/version.ts:3:28 - error TS2307: Cannot find module '@uifabric/set-version' or its corresponding type declarations.
+@uifabric/build: 3 import { setVersion } from '@uifabric/set-version';
+@uifabric/build:                              ~~~~~~~~~~~~~~~~~~~~~~~
+@uifabric/build: exec-sync.js:4:7 - error TS6133: 'chalk' is declared but its value is never read.


filed #40185 to track this

sandersn

Just looked at azure-sdk and office-ui.

@rbuckton There was one breaking change from resolve requiring its argument that I wanted to make sure was an acceptable break
@orta same, except for Array.isArray now propagates readonly-ness.
@weswigham office-ui's build is broken pretty badly. It doesn't get the right configs, and is also missing whatever .d.ts has declare module "*.scss" in many cases. Can you see what needs to be fixed here?

sandersn · 2020-09-11T21:51:05Z

tests/baselines/reference/docker/office-ui-fabric.log

+@uifabric/build:     at Process.callbackTrampoline (internal/async_hooks.js:120:14)
+@uifabric/build: [XX:XX:XX XM] x stdout:
+@uifabric/build: [XX:XX:XX XM] x create-package/plop-templates-node/just.config.ts:1:9 - error TS2451: Cannot redeclare block-scoped variable 'preset'.
+@uifabric/build: 1 const { preset, just } = require('@uifabric/build');


looks like all these config files are now in the same compilation, and since we don't recognise const x = require as creating a module, they all conflict.

Not sure how this broke; there's only one file in the directory, sitting next to a tsconfig.

This error repros locally, though of course our build may not be that similar to the real build.

@weswigham can you investigate further? I'm not sure what to look at next.

Notably, it works fine in the editor.

Maybe just.config.js is supposed to provide tsconfigs to the build process?

sandersn · 2020-09-11T21:52:44Z

tests/baselines/reference/docker/office-ui-fabric.log

+@uifabric/build:     1 const { preset, just } = require('@uifabric/build');
+@uifabric/build:               ~~~~~~
+@uifabric/build:     'preset' was also declared here.
+@uifabric/build: create-package/plop-templates-react/src/version.ts:3:28 - error TS2307: Cannot find module '@uifabric/set-version' or its corresponding type declarations.


this also works fine in the editor

sandersn · 2020-09-11T21:55:27Z

tests/baselines/reference/docker/office-ui-fabric.log

+@uifabric/build: create-package/plop-templates-react/src/version.ts:3:28 - error TS2307: Cannot find module '@uifabric/set-version' or its corresponding type declarations.
+@uifabric/build: 3 import { setVersion } from '@uifabric/set-version';
+@uifabric/build:                              ~~~~~~~~~~~~~~~~~~~~~~~
+@uifabric/build: gulp/plugins/util/getComponentInfo.ts:145:9 - error TS2322: Type 'Tag[]' is not assignable to type '{ title: string; description: string; type: null; name: string; }[]'.


repros on 3.9 and 4.0 too

sandersn · 2020-09-11T21:58:58Z

tests/baselines/reference/docker/office-ui-fabric.log

+@uifabric/build:     49   tags: {
+@uifabric/build:          ~~~~
+@uifabric/build:     The expected type comes from property 'tags' which is declared here on type 'ComponentProp'
+@uifabric/build: gulp/plugins/util/tsLanguageService.ts:25:18 - error TS2569: Type 'IterableIterator<string>' is not an array type or a string type. Use compiler option '--downlevelIteration' to allow iterating of iterators.


I'm beginning to suspect that the tsconfigs are getting ignored, since scripts/tsconfig.json targets ES2018.

sandersn · 2020-09-11T22:00:38Z

tests/baselines/reference/docker/office-ui-fabric.log

+@uifabric/build: 25       return [...files.keys()];
+@uifabric/build:                     ~~~~~~~~~~~~
+@uifabric/build: gulp/tasks/browserAdapters.ts:58:7 - error TS2554: Expected 1 arguments, but got 0.
+@uifabric/build: 58       resolve();


known breaking change, right @rbuckton -- value isn't optional anymore?

Yes, this is expected because the Promise is untyped: https://github.com/microsoft/fluentui/blob/ea8ab5cbe8d27fec5ea30524a41bd4f2a26acdd6/scripts/gulp/tasks/browserAdapters.ts#L44

sandersn · 2020-09-11T22:52:21Z

tests/baselines/reference/docker/office-ui-fabric.log

+office-ui-fabric-react: src/components/MarqueeSelection/MarqueeSelection.base.tsx:89:12 - error TS2790: The operand of a 'delete' operator must be optional.
+office-ui-fabric-react: 89     delete this._scrollableSurface;
+office-ui-fabric-react:               ~~~~~~~~~~~~~~~~~~~~~~~
+office-ui-fabric-react: src/components/Persona/Persona.deprecated.test.tsx:113:13 - error TS2322: Type 'ReactWrapper<HTMLAttributes, any, Component<{}, {}, any>>' is not assignable to type 'ReactWrapper<ImgHTMLAttributes<any>, any, Component<{}, {}, any>>'.


dom update, but from before 4.1

sandersn · 2020-09-11T22:56:46Z

tests/baselines/reference/docker/office-ui-fabric.log

+@uifabric/tsx-editor: 2 import * as monaco from '@uifabric/monaco-editor';
+@uifabric/tsx-editor:                           ~~~~~~~~~~~~~~~~~~~~~~~~~
+@uifabric/tsx-editor: src/transpiler/transpile.ts:26:11 - error TS7006: Parameter 'worker' implicitly has an 'any' type.
+@uifabric/tsx-editor: 26     .then(worker => {


also on 4.0

sandersn · 2020-09-11T23:05:25Z

tests/baselines/reference/docker/office-ui-fabric.log

+@uifabric/experiments: src/components/SelectedItemsList/Items/subcomponents/DefaultEditingItem.tsx:86:29 - error TS2339: Property 'editingInput' does not exist on type 'typeof import("*.scss")'.
+@uifabric/experiments: 86           className={styles.editingInput}
+@uifabric/experiments:                                ~~~~~~~~~~~~
+@uifabric/experiments: src/components/SelectedItemsList/SelectedPeopleList/SelectedPeopleList.test.tsx:135:9 - error TS2322: Type 'ComponentType<TriggerProps<unknown>>' is not assignable to type 'ComponentClass<ISelectedItemProps<IPersonaProps & BaseSelectedItem>, any> | FunctionComponent<ISelectedItemProps<IPersonaProps & BaseSelectedItem>> | undefined'.


repros on 4.0 too

sandersn · 2020-09-11T23:08:40Z

tests/baselines/reference/docker/office-ui-fabric.log

+@fluentui/react-checkbox: [XX:XX:XX XM] x stdout:
+@fluentui/react-checkbox: [XX:XX:XX XM] x src/next/useCheckboxClasses.tsx:15:50 - error TS2345: Argument of type 'typeof import("*.scss")' is not assignable to parameter of type 'Record<string, string>'.
+@fluentui/react-checkbox:   Property 'styles' is incompatible with index signature.
+@fluentui/react-checkbox:     Type '{ [className: string]: string; }' is not assignable to type 'string'.


repros on 4.0 too

sandersn · 2020-09-11T23:17:06Z

tests/baselines/reference/docker/office-ui-fabric.log

+@uifabric/api-docs:     at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)
+@uifabric/api-docs:     at Process.callbackTrampoline (internal/async_hooks.js:120:14)
+@uifabric/api-docs: [XX:XX:XX XM] x stdout:
+@uifabric/api-docs: [XX:XX:XX XM] x src/tableJson.ts:52:9 - error TS2322: Type 'readonly HeritageType[] | undefined' is not assignable to type 'HeritageType[] | undefined'.


due to Array.isArray's new narrowing behaviour. @orta, is this a desired error?

function f(extendsTypes: HeritageType | readonly HeritageType[]) { const e: HeritageType[] = Array.isArray(extendsTypes) ? extendsTypes : [extendsTypes]; }

sandersn

The diffs are basically OK except for office-ui-fabric, but that needs an overhaul of the build entirely. I'm going to accept the changes for now, but we should fix the build so the test is actually useful.

sandersn · 2020-09-23T20:16:44Z

tests/baselines/reference/docker/vue-next.log

+/vue-next/packages/compiler-ssr/src/index.ts → packages/compiler-ssr/dist/compiler-ssr.cjs.js...
+created packages/compiler-ssr/dist/compiler-ssr.cjs.js in ?s
+/vue-next/packages/reactivity/src/index.ts → packages/reactivity/dist/reactivity.esm-bundler.js...
+[!] (plugin rpt2) Error: /vue-next/packages/reactivity/src/collectionHandlers.ts(24,3): semantic error TS2322: Type 'T | DeepReadonly<UnwrapNestedRefs<T & Record<any, any>>>' is not assignable to type 'T'.


from #39258 -- it's probably by-design, but it's hard to tell whether it should get an exemption.

sandersn · 2020-09-23T22:57:01Z

tests/baselines/reference/user/adonis-framework.log

 node_modules/adonis-framework/src/Helpers/index.js(256,45): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
  Type 'undefined' is not assignable to type 'string'.
-node_modules/adonis-framework/src/Helpers/index.js(330,31): error TS2339: Property 'mainModule' does not exist on type 'Process'.
+node_modules/adonis-framework/src/Helpers/index.js(330,23): error TS2532: Object is possibly 'undefined'.


@types/node update

sandersn · 2020-09-23T22:58:10Z

tests/baselines/reference/user/adonis-framework.log

 node_modules/adonis-framework/src/Response/index.js(68,7): error TS1056: Accessors are only available when targeting ECMAScript 5 and higher.
 node_modules/adonis-framework/src/Response/index.js(76,15): error TS2304: Cannot find name 'Mixed'.
 node_modules/adonis-framework/src/Response/index.js(95,16): error TS2304: Cannot find name 'Html'.
+node_modules/adonis-framework/src/Response/index.js(144,12): error TS1003: Identifier expected.


error from @see (and in the rest of adonis)

sandersn · 2020-09-23T22:59:04Z

tests/baselines/reference/user/async.log

 node_modules/async/all.js(32,12): error TS2304: Cannot find name 'AsyncFunction'.
 node_modules/async/all.js(49,20): error TS2695: Left side of comma operator is unused and has no side effects.
 node_modules/async/all.js(49,46): error TS2695: Left side of comma operator is unused and has no side effects.
+node_modules/async/allLimit.js(28,9): error TS1003: Identifier expected.


unexpected @see format: @see [title]{@link reference}

sandersn · 2020-09-23T23:03:28Z

tests/baselines/reference/user/chrome-devtools-frontend.log

@@ -26,7 +25,6 @@ node_modules/chrome-devtools-frontend/front_end/Runtime.js(746,5): error TS2322:
  Type '{}' is missing the following properties from type 'Window': applicationCache, clientInformation, closed, customElements, and 224 more.
 node_modules/chrome-devtools-frontend/front_end/Runtime.js(1083,15): error TS2355: A function whose declared type is neither 'void' nor 'any' must return a value.
 node_modules/chrome-devtools-frontend/front_end/Runtime.js(1088,15): error TS2355: A function whose declared type is neither 'void' nor 'any' must return a value.
-node_modules/chrome-devtools-frontend/front_end/Tests.js(107,5): error TS2322: Type 'Timeout' is not assignable to type 'number'.


not sure whether this is an improvement in control flow or in @types/node types.

sandersn · 2020-09-24T15:42:36Z

tests/baselines/reference/user/webpack.log

-lib/FlagDependencyExportsPlugin.js(295,16): error TS2339: Property 'log' does not exist on type 'typeof WebpackLogger'.
-lib/FlagDependencyExportsPlugin.js(309,16): error TS2339: Property 'time' does not exist on type 'typeof WebpackLogger'.
-lib/FlagDependencyExportsPlugin.js(330,18): error TS2339: Property 'timeEnd' does not exist on type 'typeof WebpackLogger'.
+lib/ExportsInfo.js(1063,28): error TS1016: A required parameter cannot follow an optional parameter.


from new code; repros in 4.0 too

sandersn · 2020-09-24T15:47:38Z

tests/baselines/reference/user/uglify-js.log

  Property 'prototype' does not exist on type 'Math'.
-node_modules/uglify-js/lib/propmangle.js(70,45): error TS2339: Property 'prototype' does not exist on type 'ObjectConstructor | FunctionConstructor | StringConstructor | BooleanConstructor | NumberConstructor | ... 4 more ... | ArrayConstructor'.
+node_modules/uglify-js/lib/propmangle.js(71,44): error TS2351: This expression is not constructable.
+  Not all constituents of type 'ObjectConstructor | FunctionConstructor | StringConstructor | BooleanConstructor | NumberConstructor | ... 4 more ... | ArrayConstructor' are constructable.


better checking for construct signatures on unions? This error is correct ,at least.

sandersn · 2020-09-24T15:48:46Z

tests/baselines/reference/user/uglify-js.log

-node_modules/uglify-js/lib/parse.js(1506,35): error TS2531: Object is possibly 'null'.
-node_modules/uglify-js/lib/parse.js(1551,52): error TS2531: Object is possibly 'null'.
-node_modules/uglify-js/lib/propmangle.js(69,18): error TS2339: Property 'prototype' does not exist on type 'ObjectConstructor | FunctionConstructor | StringConstructor | BooleanConstructor | NumberConstructor | ... 4 more ... | ArrayConstructor'.
+node_modules/uglify-js/lib/parse.js(1120,17): error TS2454: Variable 'cur' is used before being assigned.


this error comes from the same information as before, and is just as correct; I'm not sure what caused it to change, though.

sandersn · 2020-09-24T15:50:00Z

tests/baselines/reference/user/uglify-js.log

  Type 'TreeTransformer' is missing the following properties from type 'TreeWalker': currentNode, filter, root, whatToShow, and 10 more.
 node_modules/uglify-js/tools/exit.js(10,37): error TS2345: Argument of type 'any[]' is not assignable to parameter of type '[code?: number | undefined]'.
  Target allows only 1 element(s) but source may have more.
+node_modules/uglify-js/tools/exports.js(1,1): error TS2303: Circular definition of import alias '"Dictionary"'.


this used to be ignored, now it's treated like a real export and gives an error because none of the references resolve.

sandersn · 2020-09-24T16:10:11Z

tests/baselines/reference/user/TypeScript-React-Starter.log

+Exit Code: 2
+Standard output:
+node_modules/@types/enzyme/index.d.ts(368,15): error TS2304: Cannot find name 'Cheerio'.
+node_modules/@types/enzyme/index.d.ts(640,69): error TS2304: Cannot find name 'Cheerio'.


@types/enzyme@2 specifies @types/cheerio@*, so it gets the newest, incompatible version...

This is a Typescript-react-starter problem, not a user problem. I'll see if we care about upgrading to a newer version of enzyme.

typescript-bot mentioned this pull request Aug 20, 2020

CI Status Thread #33716

Closed

typescript-bot force-pushed the user-baseline-updates branch from d091781 to d4ec988 Compare August 20, 2020 17:06

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 20, 2020

typescript-bot force-pushed the user-baseline-updates branch 3 times, most recently from e4644e5 to e891608 Compare August 21, 2020 00:06

sandersn reviewed Aug 21, 2020

View reviewed changes

typescript-bot force-pushed the user-baseline-updates branch 23 times, most recently from 3df14bc to 288649d Compare August 28, 2020 16:43

typescript-bot force-pushed the user-baseline-updates branch 3 times, most recently from 961d1e5 to 0000299 Compare September 2, 2020 04:22

weswigham force-pushed the master branch from 3b502f4 to 838a5e6 Compare September 2, 2020 18:46

typescript-bot force-pushed the user-baseline-updates branch 23 times, most recently from 951e867 to 452129c Compare September 8, 2020 16:41

sandersn reviewed Sep 11, 2020

View reviewed changes

Update user baselines +cc @sandersn

e597b0e

sandersn approved these changes Sep 24, 2020

View reviewed changes

Conversation

typescript-bot commented Aug 20, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sandersn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sandersn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants