Make AutoImportProviderProject work with symlinked monorepos#39679
Merged
andrewbranch merged 11 commits intomicrosoft:masterfrom Jul 22, 2020
Merged
Make AutoImportProviderProject work with symlinked monorepos#39679andrewbranch merged 11 commits intomicrosoft:masterfrom
andrewbranch merged 11 commits intomicrosoft:masterfrom
Conversation
typescript-bot
added
Author: Team
For Milestone Bug
sheetalkamat
requested changes
Jul 21, 2020
sheetalkamat
requested changes
Jul 22, 2020
Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
sheetalkamat
approved these changes
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38955
When the AutoImportProviderProject does module resolution, it needs to use its host project’s program’s resolution logic to take advantage of its special
useSourceOfProjectReferenceRedirecthandling (e.g. pretending .d.ts outputs exist when they don’t). Beyond that, the symlinks discovered during project reference resolution needed to be cached for longer than the program lifecycle (as they were prior to #37370). To minimize the cognitive footprint of moving that cache, I unified it with the existing symlinks cacheLanguageServiceHost['getProbableSymlinks'], renaming it togetSymlinkCache.