🤖 User test baselines have changed for refs/heads/master#39077
Merged
sandersn merged 1 commit intomicrosoft:masterfrom Jun 22, 2020
Merged
🤖 User test baselines have changed for refs/heads/master#39077sandersn merged 1 commit intomicrosoft:masterfrom
sandersn merged 1 commit intomicrosoft:masterfrom
Conversation
Closed
typescript-bot
force-pushed
the
user-baseline-updates
branch
29 times, most recently
from
351893e to
09b6940
Compare
typescript-bot
force-pushed
the
user-baseline-updates
branch
7 times, most recently
from
905a8e6 to
53ad18c
Compare
typescript-bot
force-pushed
the
user-baseline-updates
branch
from
53ad18c to
d574c15
Compare
sandersn
approved these changes
Jun 22, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Error code being 2 is .. OK, and probably should have been that way before.
| Exit Code: 2 | ||
| Standard output: | ||
| lib/ContextModule.js(352,32): error TS2345: Argument of type 'Pick<ContextOptions & ContextModuleOptionsExtras, "include" | "regExp" | "chunkName" | "referencedExports" | "mode" | "recursive" | ... 6 more ... | "resourceQuery">' is not assignable to parameter of type 'ContextOptions & ContextModuleOptionsExtras'. | ||
| Property 'resolveOptions' is missing in type 'Pick<ContextOptions & ContextModuleOptionsExtras, "include" | "regExp" | "chunkName" | "referencedExports" | "mode" | "recursive" | ... 6 more ... | "resourceQuery">' but required in type 'ContextModuleOptionsExtras'. |
Member
There was a problem hiding this comment.
I'm not sure why this worked before, but the code tries to assign Omit<X, "p"> to X and that definitely means you should get a "missing 'p'" error.
Member
There was a problem hiding this comment.
Previously, the function which was called here was typed as any. I think it's because it was assigned any outside the constructor. Regardless, the new type is correct.
cangSDARM
added a commit
to cangSDARM/TypeScript
that referenced
this pull request
Jun 23, 2020
* upstream/master: (58 commits) Variadic tuple types (microsoft#39094) chore: resolve suggestions Expand auto-import to all package.json dependencies (microsoft#38923) inline local functions Update bigint declaration file (microsoft#38526) Update user baselines (microsoft#39077) LEGO: check in for master to temporary branch. Add missing index.ts files to user projects (microsoft#39163) Add reason for a disabled code action (microsoft#37871) Minor fix for assertion predicates (microsoft#38710) Update LKG (microsoft#39173) Reparse top level 'await' in modules (microsoft#39084) change chore: more change chore: resolve review chore: save space fix: lint error test: add test for it chore: make isJsxAttr required chore: revert change in checker ... # Conflicts: # src/compiler/binder.ts # src/compiler/checker.ts # src/compiler/parser.ts # src/compiler/types.ts
Jack-Works
pushed a commit
to Jack-Works/TypeScript
that referenced
this pull request
Jun 24, 2020
Co-authored-by: typescript-bot <typescript@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript