isDynamicName skips parentheses for element access#39025
Merged
Conversation
Neither `x[0]` nor `x[(0)]` should be dynamic names. Previously, the latter was because `isDynamicName` didn't skip parentheses. Since the binder treats dynamic names in property assignments as assignment declarations, this incorrectly tried to create a binding for expressions like `x[(0)] = 1`. This caused an assert because `x[(0)]` would not take the dynamic name code path during binding (`hasDynamicName` returned false), but the normal code path for static names.
andrewbranch
approved these changes
Jun 11, 2020
Member
|
@typescript-bot cherry-pick this to release-3.9 |
Collaborator
|
Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @RyanCavanaugh, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.9 manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither
x[0]norx[(0)]should be dynamic names. Previously, the latter was becauseisDynamicNamedidn't skip parentheses.Since the binder treats dynamic names in property assignments as assignment declarations, this incorrectly tried to create a binding for expressions like
x[(0)] = 1.This caused an assert because
x[(0)]would not take the dynamic name code path during binding (hasDynamicNamereturned false), but the normal code path for static names.Fixes #38934