When the imported module is through node_modules and symlink to folder that isnt node_modules#37387
Merged
sheetalkamat merged 2 commits intomasterfrom Mar 16, 2020
Merged
When the imported module is through node_modules and symlink to folder that isnt node_modules#37387sheetalkamat merged 2 commits intomasterfrom
sheetalkamat merged 2 commits intomasterfrom
Conversation
…r that isnt node_modules Most of the monorepo like scenarios are like this so looking at symlink to decide if file can be imported is essential Fixes #28689
weswigham
approved these changes
Mar 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the monorepo like scenarios are like this so looking at symlink to decide if file can be imported is essential
Fixes #28689