Move individual duration properties into a performanceData object#36210
Merged
amcasey merged 1 commit intomicrosoft:masterfrom Jan 16, 2020
Merged
Move individual duration properties into a performanceData object#36210amcasey merged 1 commit intomicrosoft:masterfrom
performanceData object#36210amcasey merged 1 commit intomicrosoft:masterfrom
Conversation
Collaborator
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary |
Member
Author
|
@minestarks, VS already consumes this shape since this is what I was testing with locally. |
Member
Author
|
Not waiting for approval since the approvers of the last PR thought this was included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was supposed to be part of #35675, but I forgot to push the last commit. Good catch, @mjbvz!