🤖 User test baselines have changed for refs/heads/master#34603
Closed
typescript-bot wants to merge 1 commit intomicrosoft:masterfrom
Closed
🤖 User test baselines have changed for refs/heads/master#34603typescript-bot wants to merge 1 commit intomicrosoft:masterfrom
typescript-bot wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Closed
typescript-bot
force-pushed
the
user-update-Microsoft-20190900-refs/heads/master
branch
from
549b4ec to
bc41f55
Compare
sandersn
reviewed
Oct 22, 2019
| Type 'string' is not assignable to type 'object | object[]'. | ||
| lib/FlagDependencyExportsPlugin.js(113,27): error TS2339: Property 'setUnknownExportsProvided' does not exist on type 'typeof ExportsInfo'. | ||
| lib/FlagDependencyExportsPlugin.js(120,44): error TS2339: Property 'getExportInfo' does not exist on type 'typeof ExportsInfo'. | ||
| lib/FlagDependencyExportsPlugin.js(128,44): error TS2339: Property 'getExportInfo' does not exist on type 'typeof ExportsInfo'. |
Member
There was a problem hiding this comment.
resolving the class type instead of the instance type
sandersn
reviewed
Oct 23, 2019
| node_modules/bluebird/js/release/assert.js(11,30): error TS2339: Property 'constructor$' does not exist on type 'Error'. | ||
| node_modules/bluebird/js/release/bluebird.js(5,15): error TS2367: This condition will always return 'false' since the types 'PromiseConstructor' and 'typeof Promise' have no overlap. | ||
| node_modules/bluebird/js/release/bluebird.js(10,10): error TS2339: Property 'noConflict' does not exist on type 'typeof Promise'. | ||
| node_modules/bluebird/js/release/call_get.js(11,24): error TS2339: Property 'canEvaluate' does not exist on type 'typeof ret'. |
Member
There was a problem hiding this comment.
fails to import via require, not sure why yet
Member
There was a problem hiding this comment.
I remember this now:
// @filename: first.js
var ret = {
global: this,
isClass: true
}
module.exports = ret
// @filename: test.js
var o = require('./first')
o./**/this is a reference to the module, which is then exported, so this reference is circular. My simplification of type reference resolution stopped eagerly resolving this type, but then my fix started again. It would be nicer to not eagerly resolve, but not required. This is an OK break -- and goes back to the way it was in 3.6.
sandersn
reviewed
Oct 23, 2019
| @@ -84,6 +84,7 @@ node_modules/chrome-devtools-frontend/front_end/Tests.js(988,10): error TS2554: | |||
| node_modules/chrome-devtools-frontend/front_end/Tests.js(1033,32): error TS2339: Property 'timeline' does not exist on type 'any[]'. | |||
| node_modules/chrome-devtools-frontend/front_end/Tests.js(1040,30): error TS2339: Property 'timeline' does not exist on type 'any[]'. | |||
| node_modules/chrome-devtools-frontend/front_end/Tests.js(1084,27): error TS2339: Property 'timeline' does not exist on type 'any[]'. | |||
| node_modules/chrome-devtools-frontend/front_end/Tests.js(1123,38): error TS2339: Property 'isServiceProject' does not exist on type 'typeof Project'. | |||
Member
There was a problem hiding this comment.
same as webpack, resolving typeof X not X
Member
There was a problem hiding this comment.
Filed #34685 to track this since the fix is not the same as webpack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript