Introduce introspecing fast path for keyof intersection distribution#23986
Closed
weswigham wants to merge 2 commits intomicrosoft:masterfrom
Closed
Introduce introspecing fast path for keyof intersection distribution#23986weswigham wants to merge 2 commits intomicrosoft:masterfrom
weswigham wants to merge 2 commits intomicrosoft:masterfrom
Conversation
…preserve input union if no filtering is actually performed
Member
Author
|
cc @ahejlsberg since you got assigned to this issue a minute before I opened this PR. |
Member
|
I've just put up #24137 which performs a similar optimization but in the main path of intersection type creation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23977
This does fix the OOM crash, however right now the fast-path logic just gives up if there's a non-literal type present; handling
stringandsymbolgracefully without giving up on the fastpath is maybe worth doing.