Handle the configured project lifetime to account for files added to the project after config file gets reloaded#19138
Merged
sheetalkamat merged 2 commits intomasterfrom Oct 18, 2017
Merged
Conversation
…o ref count of configured project
Member
Author
|
@mhegazy can you please take a look. Without this fix there is potential to have open file, whose project (config file based) gets removed prematurely. |
mhegazy
approved these changes
Oct 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With earlier approach of adding open ref to the configured project while just opening the file, we can go out of sync pretty easily when configured project is updated to contain more/less of open files.
Switched to using the knowledge of open files and their relation to configured project to manage configured project's life time