fix(44560): Make PaymentRequest.show method param optional#1022
Closed
thunder-coding wants to merge 1 commit intomicrosoft:mainfrom
thunder-coding:fix-ts44560
Closed
fix(44560): Make PaymentRequest.show method param optional#1022thunder-coding wants to merge 1 commit intomicrosoft:mainfrom thunder-coding:fix-ts44560
PaymentRequest.show method param optional#1022thunder-coding wants to merge 1 commit intomicrosoft:mainfrom
thunder-coding:fix-ts44560
Conversation
Contributor
|
Thanks for helping. |
|
Looked at TypeScript-DOM-lib-generator and seems like the bug is fixed. Maybe not published yet. But for now, you can manually edit on your dev environment to keep going as you await for the release. |
Collaborator
|
Fixed by #1034 @github-actions close |
Contributor
|
Closing because @saschanaz is a code-owner of all the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
detailsPromiseparam ofPaymentRequest.showoptionalFixes microsoft/TypeScript#44560
PS: I am a first time contributor to this repository.