Merged
Conversation
Contributor
|
Looks good but I am a bit confsed with the log catcher in the utils.helpers. I thought in the end we decided not to catch logging messages or is this only there for testing purposes? |
Contributor
Author
Right, only for testing purposes. I just put it in there because I needed it across multiple test files, and I could imagine people finding use cases for this down the line - like if you want to do something nice with log messages in the GUI. |
Contributor
|
Sounds good 💃 |
This was referenced Mar 1, 2016
Closed
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Jun 27, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Jul 7, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Jul 18, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Aug 3, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Aug 3, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Aug 7, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Aug 9, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Aug 10, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Aug 16, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Aug 18, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Aug 22, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Sep 21, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
nataliejpg
pushed a commit
to nataliejpg/Qcodes
that referenced
this pull request
Oct 11, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Oct 27, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Nov 21, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
jenshnielsen
referenced
this pull request
in jenshnielsen/Qcodes
Nov 23, 2017
Make the automatic disabling of automatic SI prefixes handle arrayparameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@AdriaanRol re #44 - this PR adds a
max_sweep_delayto argument toStandardParameter, along with the existingsweep_delayargument. If you give both, then we try to waitsweep_delaybut don't generate a log warning unless the delay is longer thanmax_sweep_delay.I also changed it so negative delays don't compound - that is, if you have one instance of too long a delay, the loop won't attempt to make up the difference in the next iteration, and will not keep adding to the time error.
And for calculating delay times I switched from
datetime.now()totime.perf_counter()- which is relative, not absolute, time, but it is much higher resolution.