Fix handling of -WhatIf in core functions#213
Merged
HowardWolosky merged 2 commits intomicrosoft:masterfrom Jun 1, 2020
Merged
Fix handling of -WhatIf in core functions#213HowardWolosky merged 2 commits intomicrosoft:masterfrom
HowardWolosky merged 2 commits intomicrosoft:masterfrom
Conversation
WhatIf support has now been simiplified in all API's that eventually call into `Invoke-GHRestMethod`. There's now a single check at the top of that function which checks if it should continue or not. If it shouldn't, it early returns in order to avoid any code that might access uninitialized content from outside of the ShouldProcess blocks later on. Resolves microsoft#197
Contributor
Author
|
cc: @X-Guardian |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WhatIf support has now been simiplified in all API's that eventually
call into
Invoke-GHRestMethod. There's now a single check at thetop of that function which checks if it should continue or not. If it
shouldn't, it early returns in order to avoid any code that might access
uninitialized content from outside of the ShouldProcess blocks later on.
Resolves #197