Skip to content

Conversation

@eltociear
Copy link
Contributor

intial -> initial

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much for taking the time to contribute!

I found a few more cases of this particular typo:

git grep -i intial

Could you please fix those too?

@borchero
Copy link
Collaborator

@jameslamb we could think about adding typos as a pre-commit hook. It minimizes false positives by using a list of well-known typos rather than defining a dictionary of valid words 😄

@jameslamb
Copy link
Collaborator

@borchero oh very cool, I hadn't seen that before! Let's try it, it looks great. Could you put up a separate PR?

I'll merge this one as-is without waiting to fix the other couple uses of intial, so @eltociear can get their first contribution here and so we don't have to wait on this to add that pre-commit check.

@jameslamb jameslamb self-requested a review June 17, 2024 00:47
@jameslamb jameslamb merged commit d56a7a3 into microsoft:master Jun 17, 2024
@jameslamb
Copy link
Collaborator

thanks for taking the time to contribute, come back any time!

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants