Skip to content

Conversation

@jameslamb
Copy link
Collaborator

clang++ complains about this variable in linkers_socket.cpp being unused.

.../src/network/linkers_socket.cpp:174:7: warning: variable 'need_connect_cnt' set but not used [-Wunused-but-set-variable]
  int need_connect_cnt = 0;

That looks correct to me, based on the output of this:

git grep need_connect_cnt

Seems that that variable is being incremented but not used for anything. I suspect that's left over from some previous refactoring.

This proposes removing that unused variable.

@jameslamb jameslamb merged commit 4466349 into master Apr 19, 2024
@jameslamb jameslamb deleted the remove-unused branch April 19, 2024 22:36
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants