Skip to content

[SPIR-V][vk::SampledTexture] #6. Add remaining .Gather...() methods for vk::SampledTexture2D type. #8149

Merged
s-perron merged 1 commit intomicrosoft:mainfrom
luciechoi:gatherred
Feb 27, 2026
Merged

[SPIR-V][vk::SampledTexture] #6. Add remaining .Gather...() methods for vk::SampledTexture2D type. #8149
s-perron merged 1 commit intomicrosoft:mainfrom
luciechoi:gatherred

Conversation

@luciechoi
Copy link
Collaborator

@luciechoi luciechoi commented Feb 10, 2026

Part of #7979

TemplateType GatherRed(float2 Location, int2 Offset1, int2 Offset2, int2 Offset3, int2 Offset4, uint Status);
TemplateType GatherGreen(float2 Location, int2 Offset1, int2 Offset2, int2 Offset3, int2 Offset4, uint Status);
TemplateType GatherBlue(float2 Location, int2 Offset1, int2 Offset2, int2 Offset3, int2 Offset4, uint Status);
TemplateType GatherAlpha(float2 Location, int2 Offset1, int2 Offset2, int2 Offset3, int2 Offset4, uint Status);
TemplateType GatherCmp(float Location, float CompareValue, int2 Offset, uint Status);
TemplateType GatherCmpRed(float Location, float CompareValue, int2 Offset1, int2 Offset2, int2 Offset3, int2 Offset4, uint Status);

GatherCmpGreen, GatherCmpBlue, GatherCmpAlpha, GatherRaw are not supported.

@luciechoi luciechoi changed the title [SPIR-V] Implement remaining Gather methods for SampledTexture. [SPIR-V] Implement remaining Gather methods for SampledTexture2D. Feb 10, 2026
@luciechoi luciechoi requested a review from s-perron February 10, 2026 18:14
@luciechoi luciechoi changed the title [SPIR-V] Implement remaining Gather methods for SampledTexture2D. [SPIR-V][vk::SampledTexture] #6. Add remaining .Gather...() methods for vk::SampledTexture2D type. Feb 17, 2026
@luciechoi luciechoi requested a review from Keenuts February 18, 2026 19:54
Copy link
Collaborator

@Keenuts Keenuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Gather commit (parent commit in another PR has some comments)

@s-perron s-perron enabled auto-merge (squash) February 27, 2026 15:39
@s-perron
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@s-perron s-perron merged commit b89799d into microsoft:main Feb 27, 2026
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants