This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Conversation
adrastogi
reviewed
Jan 8, 2024
adrastogi
reviewed
Jan 8, 2024
vineeththomasalex
approved these changes
Jan 24, 2024
decriptor
reviewed
Jan 26, 2024
dhoehna
reviewed
Feb 2, 2024
| <Nullable>enable</Nullable> | ||
| <Platforms>x86;x64;arm64</Platforms> | ||
| <RuntimeIdentifiers>win-x86;win-x64;win-arm64</RuntimeIdentifiers> | ||
| <RuntimeIdentifiers>win10-x86;win10-x64;win10-arm64</RuntimeIdentifiers> |
Contributor
There was a problem hiding this comment.
These need to have the 10 remove, ya?
Author
There was a problem hiding this comment.
Per microsoft/devhome#2156, the RidGraph workaround would crash the extension, as it meant "use old runtime identifier system instead of new one" instead of "work with packages still using old win10 runtime identifiers.
Has their been a newer update/interpretation to this workaround?
Author
|
Closed since #121 was merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Initial code changes to move .NET version to .NET 8. Release notes can be found here: https://learn.microsoft.com/en-us/dotnet/core/whats-new/dotnet-8.
References and relevant issues
#55
Detailed description of the pull request / Additional comments
Created new issue #81 to document the modification of the RID workaround, once it is no longer needed in the future.
Validation steps performed
PR checklist