Add antd the list of allowed packages #1248
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrozy1
requested review from
andrewbranch,
jakebailey and
sandersn
as code owners
Member
|
In what capacity will it be used? For tests only? Or as an actual dep? (Usually people discover they need to update this after they have a PR and so we see what's going on) |
Author
|
This will be used for an actual dependency, as Gimloader will provide an api to installers that interacts with antd api |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for a future commit to https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/gimloader