Conversation
|
Hi @HSC-1, Thank you for submitting this PR! I tested this locally and it works for me, so I'd like to get this merged. However, the failing clang-format check needs to be fixed first. In order to do this, you can either merge the PR I submitted to your fork here: SimtoReal#1, or you can fix the clang-format check manually yourself by performing the following steps:
Thanks for helping us with these style changes! |
|
Hi @HSC-1, looks like the Documentation Build & Deploy / build (pull_request) check is failing due to a syntax error on ln 1578 of client.py in your latest commit here. It looks like you manually applied the clang-format to this file. Right now, our clang-format configuration is only designed for C++, so it can cause errors like this in python. Can you revert the changes to client.py in your latest commit? |
zimmy87
left a comment
There was a problem hiding this comment.
There are some remaining artifacts from the edits to client.py that we'd like to see removed before merging.
|
Thanks for submitting this PR @HSC-1! The AirSimCI Ubuntu_1804 check is failing due an issue with a CUDA repository unrelated to this fix (we're currently working on fixing this issue in a separate PR), so I am moving ahead with merging this. |
About
#3992
simSetObjectMaterial,simSetObjectMaterialFromTexturefunctionThis feature can be added to other elements when there are multiple elements as shown in the picture below.
How Has This Been Tested?
Screenshots (if appropriate):
When it is a previous function

When the current function is
