Conversation
zimmy87
suggested changes
Apr 19, 2021
Contributor
zimmy87
left a comment
zimmy87
left a comment
There was a problem hiding this comment.
Looks good for the most part, but I think a few links are wrong and some confusing text elsewhere.
lovettchris
changed the title
lovettchris
changed the title
rajat2004
reviewed
Apr 21, 2021
Contributor
rajat2004
left a comment
rajat2004
left a comment
There was a problem hiding this comment.
distance_sensor.md should be added to the navigation in mkdocs.yml so that it appears in the sidebar. mkdocs build does give an info message about the missing page, but currently doesn't treat it as a warning
Member
Author
|
@rajat2004, fixed and I added a toc level for "Sensors" to group this content as I expect it will grow over time... |
zimmy87
approved these changes
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #
lots of broken links found with a webcrawler tool.
About
Fixing broken links.
This is extracted from the much bigger PR# 3546 so I can break that PR into easier to review parts.
How Has This Been Tested?
mkdocs build and the webcrawler tool.
Screenshots (if appropriate):