Skip to content

ArduRover Vehicle support#2383

Merged
madratman merged 3 commits intomicrosoft:masterfrom
rajat2004:pr-ardurover3
Mar 27, 2020
Merged

ArduRover Vehicle support#2383
madratman merged 3 commits intomicrosoft:masterfrom
rajat2004:pr-ardurover3

Conversation

@rajat2004
Copy link
Contributor

@rajat2004 rajat2004 commented Jan 15, 2020 •
edited
Loading

Add support for ArduPilot's Rover vehicle in SITL (https://ardupilot.org/rover/)
Based on #2172 which restructures Car vehicle in AirSim (First 2 commits)

Usage instructions here - https://ardupilot.org/dev/docs/sitl-with-airsim.html#launch-rover-sitl

This was referenced Jan 15, 2020
Merged
Closed
@rajat2004 rajat2004 mentioned this pull request Jan 20, 2020
Closed
@rajat2004 rajat2004 force-pushed the pr-ardurover3 branch 3 times, most recently from 76e2e5c to efd488c Compare February 22, 2020 05:45
@rajat2004 rajat2004 mentioned this pull request Feb 25, 2020
Merged
@rajat2004
Copy link
Contributor Author

rajat2004 commented Mar 26, 2020

@madratman Rebased this on master

@rajat2004
Restructure of Car Vehicle for external firmware control
f29c7b7 
Split CarApiBase implementation from CarPawnApi and add CarApiFactory to create appropriate vehicle API based on settings
@rajat2004
Unity Car Restructure for external firmware control
08484ff
@rajat2004
Copy link
Contributor Author

rajat2004 commented Mar 27, 2020

@madratman Renamed phys_api_ to pawn_api, will soon do the other refactorings to reduce inconsistencies between Multirotor and Car
Upto you whether you prefer to merge this PR as is, and then have the others as a follow-up PR or have them all together(which I think might make it difficult to review and introduce much more number of changes than desired in a single PR)

@madratman
Copy link
Contributor

madratman commented Mar 27, 2020

I agree let's get this in first

madratman
madratman reviewed Mar 27, 2020
View reviewed changes
madratman
madratman reviewed Mar 27, 2020
View reviewed changes
madratman
madratman reviewed Mar 27, 2020
View reviewed changes
madratman
madratman reviewed Mar 27, 2020
View reviewed changes
@madratman
Copy link
Contributor

madratman commented Mar 27, 2020

All comments resolved, thanks! Nice work, @rajat2004.

@madratman madratman merged commit e24a11d into microsoft:master Mar 27, 2020
@rajat2004
Copy link
Contributor Author

rajat2004 commented Mar 27, 2020

Ahh great, thanks for the in-depth review and merging @madratman !
Could you have a look at #2356, this enabled Travis builds on Linux, Windows and MacOS, and should help prevent compilation problems on different platforms being introduced(which actually happened after the ArduCopter PR, due to the unused function being missing)

@rajat2004 rajat2004 deleted the pr-ardurover3 branch March 27, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@madratman madratman madratman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rajat2004 @madratman