Fix unity settings file

[wolf843]

test pull

[msftclas]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ wolf843 sign now
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[rajat2004]

Hey @wolf843, does this also fix the problem of an extra settings.json file getting created in the main directory if the settings.json in Documents/AirSim is not present?
The diff is pretty big so it's a bit difficult to follow

I have opened another PR with some other improvements to Unity build (#2328), and noticed this problem during that

[rajat2004]

Should be < here

[rajat2004]

Hey @wolf843, does this also fix the problem of an extra settings.json file getting created in the main directory if the settings.json in Documents/AirSim is not present?

I think the problem still persists, since the GetAirSimSettingsFileName() is the same as in the older InitializeAirsim.cs

Could be mistaken, please correct me if that's the case

[rajat2004]

@madratman I think the best way to get the settings fixed would be to do piecewise PRs or atleast smaller commits, will make it much easier to review and test

[zimmy87]

closed due to license agreement not being signed and unanswered old CR feedback