This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Convenience function for Publisher and Subscription initialization with qos option "best effort"#34
Merged
JanStaschulat merged 5 commits intomasterfrom Jun 27, 2020
Conversation
Signed-off-by: Staschulat Jan <jan.staschulat@de.bosch.com>
This was referenced Jun 15, 2020
pablogs9
previously approved these changes
Jun 15, 2020
Signed-off-by: Staschulat Jan <jan.staschulat@de.bosch.com>
pablogs9
previously approved these changes
Jun 15, 2020
jamoralp
approved these changes
Jun 15, 2020
JanStaschulat
changed the title
pablogs9
approved these changes
Jun 16, 2020
Member
|
Hello @JanStaschulat can we merge this PR? For our part it is ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two convenience functions to rclc package
resolves issue #28
Note:
unit tests are the same, additionally just check that qos option is set to best effort