-
Notifications
You must be signed in to change notification settings - Fork 459
Add 0-hop advert CLI-command #1490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
I love this feature being added to the CLI, but to clean this up for the sake of the end user, it might be nice to append "flood" to the preexisting advert command and to spell out "zerohop" for the zero hop variant so as to match the MeshCore Client App UI. Most certainly not a requirement, but just a thought to avoid having to clean this up later. |
|
@nakoeppen Thanks for the feedback! Please let me check regarding appending flood to the legacy command, as this should not interfere with legacy features |
5efe0f1 to
f84c746
Compare
f84c746 to
2e6be04
Compare
|
Changed the spelling to zerohop If I modify the "old" flood-command, it would break the "Advert"-button in the UI Any suggestions? |
@liamcottle any thoughts here? If we need to keep it as just "advert" that's fine as well. I just thought it might be a low-hanging fruit for improving CLI usability, particularly to avoid people from defaulting to the advert command and flooding the network unnecessarily as a result. |
I like that thought! Just thinking... |
I certainly think from a network integrity standpoint that this would be the best route, but input from project admins would also be appreciated! |
Add a command to CLI to allow repeater owner to send a 0-hop advert manually as this can help reduce load on the mesh.