Merged
Conversation
Contributor
mmatera
commented
Feb 6, 2021
mmatera
commented
- a fraction is zero if the numerator is zero and the denominator is not zero.
- fix MachineReal.is_approx_zero
…not zero. \n* fix MachineReal.is_approx_zero
Contributor
Author
If at the end everything works, it is OK. So, what do you think we need to change here? |
Member
Commit d686e8f where tests get added back in is what I meant. Please check over and if this is okay, just merge in - thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.