Adding an option for use Asymptote to build svg graphics by mmatera · Pull Request #1145 · mathics/Mathics

mmatera · 2021-02-05T11:18:48Z

This PR partially fix #1078.

The idea is to be able of producing SVG graphics that do not contain MathML code inside. If Asymptote is available in the system, and the symbol Settings`UseAsyForGraphics2D is set to True, when
GraphicsBox.boxes_to_xml is called, instead of using the internal code for building svg images,
GraphicsBox.boxes_to_tex is called to produce a set of asy instructions. These instructions are saved in a temporary file, which is sent to the asy interpreter in order to produce an svg file. Finally, GraphicsBox.boxes_to_xml returns and <img> tag, with the contain of this file, codified as a b64 string as src.

This allows also us to show expressions with nested graphics and equations.

… possible fail in os.getlogin()

…syforxmlgraphics

mmatera · 2021-02-07T18:58:03Z

If we agree to add this, it would be useful to set Settings`UseAsyForGraphics2D=True in mathics-django, as well as adding asymptote as a dependency there.

rocky

I can't get this to work:

I like the overall intent though.

rocky · 2021-02-21T10:12:07Z

mathics/builtin/graphics.py

        return elements, calc_dimensions

-    def boxes_to_tex(self, leaves, **options):
+    def boxes_to_tex(self, leaves, forxml=False, **options):


Adding a parameter like this feels really hacky.

The front end should be involved here. The backend merely needs to provide the underlying building blocks.

Adding a parameter like this feels really hacky.
Agree. Maybe I should hide it inside **options

The front end should be involved here. The backend merely needs to provide the underlying building blocks.

OK, but for it, I would need to merge #1140 first...

Let's wait until #1140 clears then.

The idea of these modifications is to have a working graphics engine without changing the current core. Most of the code is there, and if the control variable is not set (or set to false), we get the previous (buggy) behavior.
On the other hand, this does not clash against #1140, this is why I put this in a separated PR.

Adding a parameter like this feels really hacky.

The front end should be involved here. The backend merely needs to provide the underlying building blocks.
Regarding this, I put forxml as an optional parameter.

rocky

I believe there is code in the tree drawing routines of pymathics-graph that suggest how to scale the text font size based the distance between nodes which here would be applied to axis labels.

mmatera · 2021-02-21T12:58:16Z

I can't get this to work:

I like the overall intent though.

Stupid questions:

Do you have asymptote installed?
Can your asymptote installation to get svg`s from asy text files?

rocky · 2021-02-21T15:45:35Z

mathics/core/expression.py

    def is_zero(self) -> bool:
-        return self.numerator().is_zero and not self.denominator().is_zero()
+        return self.numerator().is_zero and not(self.denominator().is_zero)



Should this be in a separate PR. It fixes a current bug and is not specific to asymptote, right?

I put this because I got CI errors due to PossibleZeroQ. I removed this change from this PR. Please look at #1164.

rocky · 2021-02-21T15:55:26Z

I can't get this to work:

I like the overall intent though.

Stupid questions:

Do you have asymptote installed?

Can your asymptote installation to get svg`s from asy text files?

I have asymptote installed. BTW if I didn't I would expect changing Settings`UseAsyForGraphics2D=True would warn me that I am doing something stupid, right?
I am getting the SVG's created in my tempdir with the text added, so I guess the answer is "yes" here too.

Given the above, I am guessing there is some coordination that needs to go on with Mathics-Django. In other words this gets created, but Mathics-Django doesn't know that it has to do something special go get this image pulled in, right?

rocky · 2021-02-21T15:58:05Z

BTW although this is really good stuff, I am delighted we didn't delay the last release further to try to get this in.

mmatera · 2021-02-21T23:53:44Z

I can't get this to work:

I like the overall intent though.

Stupid questions:

Do you have asymptote installed?

Can your asymptote installation to get svg`s from asy text files?
* I have asymptote installed. BTW if I didn't I would expect changing  `` Settings`UseAsyForGraphics2D=True `` would warn me that I am doing something stupid, right?

* I am getting the SVG's created in my tempdir with the text added, so I guess the answer is "yes" here too.
Given the above, I am guessing there is some coordination that needs to go on with Mathics-Django. In other words this gets created, but Mathics-Django doesn't know that it has to do something special go get this image pulled in, right?

I tried with the master branch of mathics-django and it works for me, with this branch of Mathics. I have created a PR in mathics-django that sets the variable to True. @rocky, please have a look when you have time.

rocky · 2021-02-27T16:37:08Z

I spent some time tracking down what's up. If I use firefox I see the information. But if I use google chrome I don't.

In the chrome cases I do see:

Request URL: 
data:image/svg+xml;base64,PHN2ZyB2ZXJzaW9uPScxL ... Zz4=

getting sent back.

rocky · 2021-02-27T16:40:30Z

It also doesn't work on the opera browser

mmatera · 2021-03-02T21:08:00Z

Updates:

I moved this code to a pymathics module, in order to reduce the overhead in the core CI. See pymathics-asy
The issues with Opera and Chrome are related to the way in which tags are interpreted. To fix this, I think we need to work on the js interface of mathics-django. The other possibility would be to modify mathics core, but it would require more sophisticated changes.

rocky · 2021-03-02T21:34:00Z

I moved this code to a pymathics module, in order to reduce the overhead in the core CI. See pymathics-asy

@mmatera Ok. So is this branch obsolete? Or in need of code removal/update?

mmatera · 2021-03-04T18:13:53Z

I close this because all the code is inside pymathics-asy.

mmatera added 6 commits February 5, 2021 08:03

Adding an option for use asy to build svg graphics

cef9469

sending img with b64 encoded svg instead of plane svg

18d9c3d

Fixing boxes_to_tex return string to match with tests.

6b52d26

clean

3eaa4ca

small fixes to PossibleZeroQ

4edae89

more PossibleZeroQ fixes

7857d42

mmatera mentioned this pull request Feb 5, 2021

Text (in Graphics) is broken #1078

Closed

mmatera changed the title ~~Adding an option for use Asyptote to build svg graphics~~ Adding an option for use Asymptote to build svg graphics Feb 5, 2021

mmatera requested review from GarkGarcia and rocky February 5, 2021 16:49

mmatera added 2 commits February 6, 2021 11:52

Fix asy output for compabitibility with the doc generator. In , catch…

12fea19

… possible fail in os.getlogin()

Add changes to the Changes list

b896993

mmatera mentioned this pull request Feb 6, 2021

Use mathics scanner release #1146

Merged

mmatera added 4 commits February 6, 2021 15:43

fix density plots

b97bbb9

Merge branch 'master' of https://github.com/mathics/Mathics into usea…

3ad44bc

…syforxmlgraphics

Merge branch 'master' into useasyforxmlgraphics

a4d8ec5

Merge remote-tracking branch 'upstream/master' into useasyforxmlgraphics

9079351

merge

15216ae

rocky mentioned this pull request Feb 16, 2021

ModuleNotFoundError: No module named 'mathics_django.web.urls' #1153

Closed

rocky reviewed Feb 21, 2021

View reviewed changes

mmatera added 4 commits February 21, 2021 18:07

merge

e21f49b

cleanup

08d4b63

hide forxml parameter

4b4ddb3

cleanup. Adding warning messages

108dfc3

mmatera closed this Mar 4, 2021

rocky mentioned this pull request Mar 8, 2021

Delete worksheets Mathics3/Mathics3-django#26

Merged

mmatera deleted the useasyforxmlgraphics branch March 14, 2021 18:28

Uh oh!

Conversation

mmatera commented Feb 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmatera commented Feb 7, 2021

Uh oh!

rocky left a comment

Choose a reason for hiding this comment

Uh oh!

rocky Feb 21, 2021

Choose a reason for hiding this comment

Uh oh!

mmatera Feb 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rocky Feb 21, 2021

Choose a reason for hiding this comment

Uh oh!

mmatera Feb 21, 2021

Choose a reason for hiding this comment

Uh oh!

mmatera Feb 21, 2021

Choose a reason for hiding this comment

Uh oh!

rocky left a comment

Choose a reason for hiding this comment

Uh oh!

mmatera commented Feb 21, 2021

Uh oh!

rocky Feb 21, 2021

Choose a reason for hiding this comment

Uh oh!

mmatera Feb 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rocky commented Feb 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rocky commented Feb 21, 2021

Uh oh!

mmatera commented Feb 21, 2021

Uh oh!

rocky commented Feb 27, 2021

Uh oh!

rocky commented Feb 27, 2021

Uh oh!

mmatera commented Mar 2, 2021

Uh oh!

rocky commented Mar 2, 2021

Uh oh!

mmatera commented Mar 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mmatera commented Feb 5, 2021 •

edited

Loading

mmatera Feb 21, 2021 •

edited

Loading

mmatera Feb 21, 2021 •

edited

Loading

rocky commented Feb 21, 2021 •

edited

Loading