Open
Conversation
mariamjamal94
requested review from
mnoman09,
oakbani and
rashidsp
and removed request for
rashidsp
rashidsp
requested changes
Sep 5, 2019
Collaborator
rashidsp
left a comment
rashidsp
left a comment
There was a problem hiding this comment.
Looks good! just minor comments.
CHANGELOG.md
Outdated
|
|
||
| ### New Features: | ||
| * Added support for event batching via the event processor. | ||
| * Events generated by methods like `activate`, `track`, and `is_feature_enabled` will be held in a queue until the configured batch size is reached, or the configured flush interval has elapsed. Then, they will be combined into a request and sent to the event dispatcher. |
Collaborator
There was a problem hiding this comment.
nit. combined into a request batched into a single payload
CHANGELOG.md
Outdated
| * Added support for event batching via the event processor. | ||
| * Events generated by methods like `activate`, `track`, and `is_feature_enabled` will be held in a queue until the configured batch size is reached, or the configured flush interval has elapsed. Then, they will be combined into a request and sent to the event dispatcher. | ||
| * To configure event batching, set the `batch_size` and `flush_interval` properties while initializing the `BatchEventProcessor` and then passing this `event_processor` to optimizely instance. | ||
| * Event batching is disabled by default. To enable event batching, set the `default_start` property to `True` while initializing `BatchEventProcessor` or call `start()` on the processor instance explicitly. `batch_size` defaults to `10`. `flush_interval` defaults to `30000` Milliseconds. |
Collaborator
There was a problem hiding this comment.
nit. milliseconds, m in lowercase
README.md
Outdated
| | -- | -- | -- | ||
| | `default_start` | False | If set to `True`, starts the consumer thread upon initialization of `BatchEventProcessor`. | ||
| | `event_queue` | 1000 | `queue.Queue(maxsize=1000)`. Queues individual events to be batched and dispatched by the executor. | ||
| | `event_dispatcher` | None | Used to dispatch event payload to Optimizely. |
Collaborator
There was a problem hiding this comment.
Let's comment on what this is set to if it is None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary