Add a warning when using source = "."#204
Merged
thunderhook merged 6 commits intomapstruct:mainfrom Jul 23, 2024
Merged
Conversation
thunderhook
reviewed
Jul 21, 2024
Contributor
thunderhook
left a comment
thunderhook
left a comment
There was a problem hiding this comment.
Thanks @hduelme! Works great!
Just a nit-pick and a note about an additional test. Thanks in advance!
src/main/java/org/mapstruct/intellij/inspection/ThisUsedAsSourcePropertyInspection.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@thunderhook thanks for the review. I also added tests if there is no source property and for the case |
Contributor
|
Very nice, thanks for implementing it so quickly @hduelme . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented #203. As suggested for each source parameter a quick fix to replace the source parameter is given.