Deterministically consistent set data #14148
Open
+226
−215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a small script that would fetch set information from the Scryfall API (can include in a separate PR under
Utils), and use this to consistently generate thecards.addcalls for a given Set class.The idea here being that it would be a handy way to quickly centralise in code what's missing or not from being implemented without the need of needing to go back and forth between Github and my IDE (without assuming the Github issue was truly up to date), but also to ensure that set data was correct, and deterministically ordered (by name and then collector number) for human-readability.
I've ran this script against a few sets already where the results seem safe and/or welcome. In most cases it's just reordered what was already there to be consistent. In some cases it's added in line comments for where we're missing card classes. In a few cases it's added in additional printing information that was previously overlooked and missing.