Remove Utils/legacy gen_types_list.pl #14145
Open
+1
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of freeform strings. Whitespace cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is safe to clean up. It made sense in the past when cards were implemented with types being passed in as free-form String values.
Given everything now uses Enums (did some quick
grep'ing to confirm this) and the presence of Universes Beyond with some card types featuring sparsely... I don't think this script which hasn't been updated in years serves much value anymore.In doing the above audit, I did spot a single card had some extra whitespace in it, which I fixed.
I have also confirmed that I cannot find reference to this Perl script elsewhere in the codebase.