GUI: Change deck selection to combobox #14131

johannes-wolf · 2025-12-20T15:26:01Z

Idea: Have a list of recently used decks when joining/creating a table instead of having to select the file each time you want to change the deck.

Change the filename edit in the NewPlayerPanel to a ComboBox that remembers the last $n$ decks used. Selecting a deck file using the file dialog directly adds it to the list of recent decks; changing the selection moves the selected item to the front of the recent list.

There are multiple ways of accessing preferences and it is not really clear to me, which one is the correct/modern one. @JayDi85

I have not touched the tournament dialog, but if this change gets accepted I would like to also
use the same mechanism there.

The deck editor could also use the path/directory of the recent deck as current path for
the file chooser. What do you think?

For a separate PR: A button to clear preferences (such as this one) in the preferences panel would
be a good addition, I guess.

Here are some screenshots:

Also remember a history of the last 5 used decks to make deck selection faster.

JayDi85

Must be fine but require some improves:

Make shared code and add same for new tourney and join dialogs;
Test use cases with new app install without recent files (you can remove some settings by regedit, see here);
Increase popup rows count from 5 to 10 and show it all in combobox (if it has scrollbar then find and change property like setMaximumRowCount);
Make sure GUI works fine with very long paths (it's allow to see and select without errors, freeze or GUI blocking);
Add screenshots to the started topic with new GUI elements;

JayDi85 · 2025-12-20T16:02:03Z

Mage.Client/src/main/java/mage/client/table/NewPlayerPanel.java

+            try {
+                String selection = cbPlayerDeck.getSelectedItem().toString();
+                MagePreferences.putRecentDeckFile(selection);
+            } catch (NullPointerException ex) { /* Ignore */ }


it's better to check cbPlayerDeck.getSelectedItem() for null instead catch error

also addActionListener will catch any events so make sure it's will raise 1 event instead multiple times each button/char edit, clicks or other user manipulations;

Use cases example:

Autoload deck file name on open dialog (it's already in old code but maybe broken in last releases -- in normal use cases GUI must load last used deck and insert it to the player deck);

Choose deck by file explorer;

Enter copied deck name by ctrl+v;

Same 1-3 features for tournament dialog;

Same 1-3 features for table join dialog;

JayDi85 · 2025-12-20T16:10:44Z

Mage.Client/src/main/java/mage/client/table/NewPlayerPanel.java

        fcSelectDeck.addChoosableFileFilter(new DeckFileFilter("dck", "XMage's deck files (*.dck)"));
-        this.txtPlayerDeck.setText("");
-        this.txtPlayerName.setText(ClientDefaultSettings.computerName);
+        cbPlayerDeck.setEditable(true);;


There are .form files for some GUI dialogs (old netbean 8 ide, see wiki docs -- it used to auto-generate some java code). So it also must be changed too. If don't have it then it's not critical -- I'll modify it later after merge.

I cannot get Netbeans 8 to run on my Linux machine; thank you!

Mage.Client/src/main/java/mage/client/table/NewPlayerPanel.java

JayDi85 · 2025-12-20T16:38:48Z

MageFrame.getPreferences() is better way to access preferences. Example:

dialog.cbCardRenderImageFallback.setSelectedItem(MageFrame.getPreferences().get(KEY_CARD_RENDERING_IMAGE_MODE, CardRenderMode.MTGO.toString()));

JayDi85 · 2025-12-20T16:41:16Z

The deck editor could also use the path/directory of the recent deck as current path for
the file chooser. What do you think?

Yes, it will be fine to use last recent file's dir instead old way directory

- Support resizing the JoinTable dialog - Fix re-loading the list of recent decks - Add tooltips that show the full path - Add a context menu to clear the list of recent decks

johannes-wolf · 2025-12-20T20:19:01Z

I added screenshots of the feature. To make the combobox fully show the filenames I did the following:

The JoinTable dialog is now resizable (horizontal)
The combobox adds tooltips for all items: hovering in a cropped list shows the full path

Also a context menu to clear the list got added.

johannes-wolf · 2025-12-20T20:27:01Z

I have not yet added the feature to the NewTournamentDialog as I am not sure where shared code should be added :(

JayDi85 · 2025-12-20T22:49:24Z

You can store shared code in new Mage.Client/src/main/java/mage/client/util/RecentFilesUtil.java or like that (work with recent lists, add, remove, load to combobox, etc — just use combobox param in all methods and work with it).

Mage.Client/src/main/java/mage/client/table/NewPlayerPanel.java

johannes-wolf · 2025-12-21T00:37:17Z

I got something wrong… the NewTournamentTable does not really need anything but the last directory logic from the new recent decklist feature.

So I am not 100% happy with having the new RecentDecklistUtil class and would rather move all the logic (back) to the NewPlayerPanel but keep the utility functions to get, set and clear the list in the RecentDecklistUtil. You decide.

I've added just the “Clear list” item to the list and removed the right-click menu.
Or did you mean a real Dropdown button with no option to enter text?

I've tested it a lot and it works very nice!

johannes-wolf · 2025-12-21T13:24:20Z

Another question: Why don't we just remove the form file(s)? Especially for simple panels/dialogs like this, there is no real need for them; those can just be built in code.

johannes-wolf · 2025-12-22T12:29:12Z

Ok… I changed this (again):

Moved the combobox and "..." button to its own panel DecklistChooser that handles all the combobox related logic
The settings are available as static methods in the RecentDecklistUtil helper class to handle access & validation
The NewPlayerPanel just embeds the DecklistChooser instead of doing the logic itself. This way we have a single encapsulated class handling the recent logic.

What I would like to do:

Remove the Form-File of DecklistChooser and use a hand coded GridLayout instead of the (verbose) autogenerated layout code.

JayDi85 · 2025-12-22T12:51:25Z

Why don't we just remove the form file(s)? Especially for simple panels/dialogs like this, there is no real need for them; those can just be built in code.

It's good and must be final destination for all GUI dialogs (there are left only few dialogs like preferences and tables), but it's very hard. NetBean's form files uses xml and generate code with GroupLayout. It's almost impossible to manual modify that code due multiple places (vertical and horizontal groups) and per pixels layout. Also it's not support resizing (well, devs do not add it to original forms). So the best way -- rework dialog structure from scratch. See related commits from #969 with hi-dpi compatible forms rework and BorderLayout usage like 8186b35.

johannes-wolf · 2025-12-22T12:54:53Z

Why don't we just remove the form file(s)? Especially for simple panels/dialogs like this, there is no real need for them; those can just be built in code.

It's good and must be final destination for all GUI dialogs (there are left only few dialogs like preferences and tables), but it's very hard.

Sorry, I did not really understand: Form files should stay or get removed?
Should I remove the form file for the panel and use the BorderLayout?

JayDi85 · 2025-12-22T13:04:59Z

Form files are netbeans only artifacts... It's not used by real app -- only by ide's visual designer. Every time you modify visual form -- it will save updated form file and generate whole java code between GEN-BEGIN text blocks in java file (components definition, visual structure and events):

So after form file remove -- it still workable, but you can't modify dialog in netbeans anymore. After that you must modify all GUI code manually without any visual designer:

GroupLayout is very hard layout, so it's better to rework for better things like BorderLayout.

P.S. I'll later test your branch for netbeans compatibility.

johannes-wolf · 2025-12-23T11:03:59Z

Here is also a follow-up branch (based on this one) to remove the Form-File and use a GridBagLayout which actually simplifies the code and improves the overal dialog layout (more efficient use of space).

Let me know if I should merge those changes into this PR.

Here are some updated screenshots:

johannes-wolf · 2025-12-30T14:41:01Z

Forgot to mention the form removal PR: johannes-wolf#1

JayDi85 · 2025-12-30T14:42:19Z

Mage.Client/src/main/java/mage/client/components/DecklistChooser.java

+            }
+        });
+
+        setLayout(new GridBagLayout());


Please, replace GridBag layout by another one like BorderLayout. gridbag is the most hardest to setup and support layout in whole swing collection -- it's better do not use it at all.

See example with game panel:
https://github.com/magefree/mage/blob/4941e2f19334ae6d9880350b94ec0919c84d3456/Mage.Client/src/main/java/mage/client/game/GamePanel.java#L256C9-L272C73

I've changed to BorderLayout. But I don't share the opinion that GridBag is hard to setup/read. BorderLayout is very strange as it seems to be meant for very simple use-cases and therefore needs all this JPanel nesting that GridBag does not need.

If you are ok with removing the form file, I will merge that PR into this one and also change the layout to BorderLayout. Let me know :) (The PR also improves layout, as space is used more efficiently.)

JayDi85 · 2025-12-31T12:04:26Z

@johannes-wolf what's your current tools for code edition (normal code, GUI)?

johannes-wolf · 2025-12-31T13:51:29Z

@johannes-wolf what's your current tools for code edition (normal code, GUI)?

I've installed IntelliJ for Java but use Emacs for everything else.

GUI: Change deck selection to combobox

a33b1ee

Also remember a history of the last 5 used decks to make deck selection faster.

github-actions bot added the client label Dec 20, 2025

JayDi85 requested changes Dec 20, 2025

View reviewed changes

GUI: Improve recent decks list

665b5cb

- Support resizing the JoinTable dialog - Fix re-loading the list of recent decks - Add tooltips that show the full path - Add a context menu to clear the list of recent decks

johannes-wolf requested a review from JayDi85 December 20, 2025 20:22

JayDi85 reviewed Dec 20, 2025

View reviewed changes

Mage.Client/src/main/java/mage/client/table/NewPlayerPanel.java Outdated Show resolved Hide resolved

Mage.Client/src/main/java/mage/client/table/NewPlayerPanel.java Outdated Show resolved Hide resolved

GUI: Move recent-decklist logic to a new file

bc1d9be

johannes-wolf requested a review from JayDi85 December 21, 2025 00:37

JayDi85 self-assigned this Dec 22, 2025

GUI: Move decklist selection to DecklistChooser

0862be5

johannes-wolf force-pushed the new-player-dialog-deck-history branch from b58a2fd to 0862be5 Compare December 23, 2025 10:00

GUI: Add "Generate" to the new Decklist Panel

a6f1c19

JayDi85 reviewed Dec 30, 2025

View reviewed changes

Replace GridBagLayout with BorderLayout

4c78588

johannes-wolf requested a review from JayDi85 December 30, 2025 15:15

GUI: Change deck selection to combobox #14131

Are you sure you want to change the base?

GUI: Change deck selection to combobox #14131

Conversation

johannes-wolf commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JayDi85 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JayDi85 Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

JayDi85 Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

johannes-wolf Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JayDi85 commented Dec 20, 2025

Uh oh!

JayDi85 commented Dec 20, 2025

Uh oh!

johannes-wolf commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johannes-wolf commented Dec 20, 2025

Uh oh!

JayDi85 commented Dec 20, 2025

Uh oh!

Uh oh!

Uh oh!

johannes-wolf commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johannes-wolf commented Dec 21, 2025

Uh oh!

johannes-wolf commented Dec 22, 2025

Uh oh!

JayDi85 commented Dec 22, 2025

Uh oh!

johannes-wolf commented Dec 22, 2025

Uh oh!

JayDi85 commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johannes-wolf commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johannes-wolf commented Dec 30, 2025

Uh oh!

JayDi85 Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johannes-wolf Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johannes-wolf Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JayDi85 commented Dec 31, 2025

Uh oh!

johannes-wolf commented Dec 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

johannes-wolf commented Dec 20, 2025 •

edited

Loading

JayDi85 left a comment •

edited

Loading

johannes-wolf commented Dec 20, 2025 •

edited

Loading

johannes-wolf commented Dec 21, 2025 •

edited

Loading

JayDi85 commented Dec 22, 2025 •

edited

Loading

johannes-wolf commented Dec 23, 2025 •

edited

Loading

JayDi85 Dec 30, 2025 •

edited

Loading

johannes-wolf Dec 30, 2025 •

edited

Loading

johannes-wolf Dec 30, 2025 •

edited

Loading