Merged
Conversation
Member
|
Thanks for the PR. I left some review comments mostly to clean it up a little bit. |
Contributor
Author
|
@ychin Hrm, I don't see any comments - is it possible you didn't click "Add review" 😄? Thanks! |
ychin
reviewed
Nov 5, 2018
Member
|
Yes I did forget to. I added the comments. |
Contributor
Author
|
Since the purpose of this file is to indicate the license that applies to the code, I removed both the Summary section as proposed by @ychin and also the manual copyright declaration since it's still present in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lack of an explicit license is holding back a potential contributor from submitting patches: #751 (comment)
Looking thru the macvim repo, and from what appears to be common practice within the vim community, seems to indicate that the vim license in
uganda.txtis considered a widely adopted default.Consequently, I took the legalese from
uganda.txtand|manual-copyright|and created a new LICENSE file.Hope this helps,