Merged
Conversation
docs/source/components/device.rst
Outdated
| A graph representing the accuracy of the device clock with respect to the host clock. We had 3 devices connected (OAK PoE cameras), all were hardware synchronized using `FSYNC Y-adapter <https://docs.luxonis.com/projects/hardware/en/latest/pages/FSYNC_Yadapter/>`__. | ||
| Raspberry Pi (the host) had an interrupt pin connected to the FSYNC line, so at the start of each frame the interrupt happened and the host clock was recorded. Then we compared frame (synced) timestamps with | ||
| host timestamps and computed the standard deviation. For the histogram above we ran this test for about 7 hours. | ||
| host timestamps and computed the standard deviation. For the histogram above we ran this test for about 3 hours. |
Contributor
There was a problem hiding this comment.
IMO we should avoid the following language: "for about " . Instead we can use "approximately" or simply "For 3 hours"
Erol444
commented
Dec 11, 2023
SzabolcsGergely
approved these changes
Dec 11, 2023
Contributor
SzabolcsGergely
left a comment
SzabolcsGergely
left a comment
There was a problem hiding this comment.
LGTM. Great improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.