Skip to content

Conversation

@nic-kulowiec
Copy link
Contributor

Addresses #334 issue on Solaris systems.

I would normally want a successful repo build before submitting PR. However, following the normal source instructions provided via a repo clone do not give me the ability to make a full build for lsof from the master branch then. It looks like a Makefile issue not including all paths and pre-reqs under Solaris. That is a complete other issue.

That said, the latest Release builds properly with this fix in place even if the github clone build fails. This alternative is better than providing a "corrected" rnode4.h as outlined in #334 .

I feel I am missing another way to solve this with a more elaborate fix, but due to a lack of time, I am providing this as-is until someone else can evaluate the validity of this "solution." My apologies ahead of time if I did not think further outside of the box and come up with a better solution.

Regards,

-Nic

@jiegec
Copy link
Member

jiegec commented Dec 15, 2025

Let's merge this first, until someone comes up with a better solution.

@jiegec jiegec merged commit 39762ae into lsof-org:master Dec 15, 2025
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants